Factored stdio parsing out of graph_json.

Factored stdio parsing out of graph_json.

These functions will be used in a future CL to show debugging info for
stoppage alerts.

Also added additional testing.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2620713002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0c9efe760d2cb739ac5cc81463961afd0a4c710b

[sullivan, 2017-01-09 15:54:21]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 15:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sullivan, 2017-01-09 15:54:31]

sullivan@chromium.org changed reviewers:
+ eakuefner@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:58:41]

Dry run: Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[sullivan, 2017-01-09 16:09:41]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:09:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 16:13:59]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[sullivan, 2017-01-09 16:27:50]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:27:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:32:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 16:32:09]

Dry run: Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[sullivan, 2017-01-09 16:42:21]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:42:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 17:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 17:01:16]

Dry run: This issue passed the CQ dry run.

[eakuefner, 2017-01-09 21:45:19]

lgtm

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
File dashboard/dashboard/common/utils.py (right):

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
dashboard/dashboard/common/utils.py:471: no_details = (None, None, None, None,
None)
I'm a little worried about using such a large tuple because of the potential for
confusion. Is it worth using a POD instead? Up to you.

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
dashboard/dashboard/common/utils.py:503: bot = re.sub(r'[ \(\)]', '_', bot)
Is this needed because it's a substitution that Logdog makes? Otherwise,
urllib.quote will already urlencode the parens and spaces.

[eakuefner, 2017-01-09 21:46:20]

Would also like BUG= here.

[sullivan, 2017-01-09 22:12:37]

Description was changed from

==========
Factored stdio parsing out of graph_json.

These functions will be used in a future CL to show debugging info for
stoppage alerts.

Also added additional testing.
==========

to

==========
Factored stdio parsing out of graph_json.

These functions will be used in a future CL to show debugging info for
stoppage alerts.

Also added additional testing.

BUG=catapult:#3132
==========

[sullivan, 2017-01-09 22:12:42]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:12:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 22:14:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483999962330130,
"parent_rev": "cc4ede7dec5c85f6166b882d553fc931b65bc464", "commit_rev":
"0c9efe760d2cb739ac5cc81463961afd0a4c710b"}

[commit-bot: I haz the power, 2017-01-09 22:14:23]

Description was changed from

==========
Factored stdio parsing out of graph_json.

These functions will be used in a future CL to show debugging info for
stoppage alerts.

Also added additional testing.

BUG=catapult:#3132
==========

to

==========
Factored stdio parsing out of graph_json.

These functions will be used in a future CL to show debugging info for
stoppage alerts.

Also added additional testing.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2620713002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-09 22:14:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[sullivan, 2017-01-09 22:20:36]

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
File dashboard/dashboard/common/utils.py (right):

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
dashboard/dashboard/common/utils.py:471: no_details = (None, None, None, None,
None)
On 2017/01/09 21:45:19, eakuefner wrote:
> I'm a little worried about using such a large tuple because of the potential
for
> confusion. Is it worth using a POD instead? Up to you.

I think it's okay because this method is mostly used by the two methods below.

https://codereview.chromium.org/2620713002/diff/60001/dashboard/dashboard/com...
dashboard/dashboard/common/utils.py:503: bot = re.sub(r'[ \(\)]', '_', bot)
On 2017/01/09 21:45:19, eakuefner wrote:
> Is this needed because it's a substitution that Logdog makes? Otherwise,
> urllib.quote will already urlencode the parens and spaces.

Yes, exactly, logdog does totally different substitution than url encoding.