Factored stdio parsing out of graph_json.

dashboard/dashboard/common/utils.py

Index: dashboard/dashboard/common/utils.py
diff --git a/dashboard/dashboard/common/utils.py b/dashboard/dashboard/common/utils.py
index 2c79ffd42829adccc0cbb4b0f2d7adcb73f552c5..4e2350b43cab19930990188a5332e043d293ffa0 100644
--- a/dashboard/dashboard/common/utils.py
+++ b/dashboard/dashboard/common/utils.py
@@ -9,6 +9,7 @@ import logging
 import os
 import re
 import time
+import urllib
 
 from apiclient import discovery
 from apiclient import errors
@@ -464,3 +465,42 @@ def FetchURL(request_url, skip_status_code=False):
         'ERROR %s checking %s', response.status_code, request_url)
     return None
   return response
+
+
+def GetBuildDetailsFromStdioLink(stdio_link):
+  no_details = (None, None, None, None, None)

[eakuefner, 2017/01/09 21:45:19]

I'm a little worried about using such a large tuple because of the potential for
confusion. Is it worth using a POD instead? Up to you.

[sullivan, 2017/01/09 22:20:36]

I think it's okay because this method is mostly used by the two methods below.

+  m = re.match(r'\[(.+?)\]\((.+?)\)', stdio_link)
+  if not m:
+    # This wasn't the markdown-style link we were expecting.
+    return no_details
+  _, link = m.groups()
+  m = re.match(
+      r'(https{0,1}://.*/([^\/]*)/builders/)'
+      r'([^\/]+)/builds/(\d+)/steps/([^\/]+)', link)
+  if not m:
+    # This wasn't a buildbot formatted link.
+    return no_details
+  base_url, master, bot, buildnumber, step = m.groups()
+  bot = urllib.unquote(bot)
+  return base_url, master, bot, buildnumber, step
+
+
+def GetBuildbotStatusPageUriFromStdioLink(stdio_link):
+  base_url, _, bot, buildnumber, _ = GetBuildDetailsFromStdioLink(
+      stdio_link)
+  if not base_url:
+    # Can't parse status page
+    return None
+  return '%s%s/builds/%s' % (base_url, urllib.quote(bot), buildnumber)
+
+
+def GetLogdogLogUriFromStdioLink(stdio_link):
+  base_url, master, bot, buildnumber, step = GetBuildDetailsFromStdioLink(
+      stdio_link)
+  if not base_url:
+    # Can't parse status page
+    return None
+  bot = re.sub(r'[ \(\)]', '_', bot)

[eakuefner, 2017/01/09 21:45:19]

Is this needed because it's a substitution that Logdog makes? Otherwise,
urllib.quote will already urlencode the parens and spaces.

[sullivan, 2017/01/09 22:20:36]

Yes, exactly, logdog does totally different substitution than url encoding.

+  s_param = urllib.quote('chrome/bb/%s/%s/%s/+/recipes/steps/%s/0/stdout' % (
+      master, bot, buildnumber, step), safe='')
+  return 'https://luci-logdog.appspot.com/v/?s=%s' % s_param