Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2620613006: Check if a PWA is installed before checking the service worker and icon. (Closed)
Patch Set: Add missing enum value Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index a8a21c596d725c180fcbc12493b0883a405a0afa..8ae8d3c3811869b3aaf3cf342be763678a4dab16 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -107,6 +107,9 @@ bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
native_app_package_ = ConvertJavaStringToUTF8(env, japp_package);
icon_url_ = GURL(ConvertJavaStringToUTF8(env, jicon_url));
+ if (!CheckIfShouldShowBanner())
+ return false;
+
return ManifestIconDownloader::Download(
web_contents(), icon_url_, GetIdealIconSizeInPx(),
GetMinimumIconSizeInPx(),
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698