Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2620613006: Check if a PWA is installed before checking the service worker and icon. (Closed)
Patch Set: Add missing enum value Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/banners/app_banner_manager_android.h" 5 #include "chrome/browser/android/banners/app_banner_manager_android.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 const JavaParamRef<jobject>& obj, 100 const JavaParamRef<jobject>& obj,
101 const JavaParamRef<jobject>& japp_data, 101 const JavaParamRef<jobject>& japp_data,
102 const JavaParamRef<jstring>& japp_title, 102 const JavaParamRef<jstring>& japp_title,
103 const JavaParamRef<jstring>& japp_package, 103 const JavaParamRef<jstring>& japp_package,
104 const JavaParamRef<jstring>& jicon_url) { 104 const JavaParamRef<jstring>& jicon_url) {
105 native_app_data_.Reset(japp_data); 105 native_app_data_.Reset(japp_data);
106 app_title_ = ConvertJavaStringToUTF16(env, japp_title); 106 app_title_ = ConvertJavaStringToUTF16(env, japp_title);
107 native_app_package_ = ConvertJavaStringToUTF8(env, japp_package); 107 native_app_package_ = ConvertJavaStringToUTF8(env, japp_package);
108 icon_url_ = GURL(ConvertJavaStringToUTF8(env, jicon_url)); 108 icon_url_ = GURL(ConvertJavaStringToUTF8(env, jicon_url));
109 109
110 if (!CheckIfShouldShowBanner())
111 return false;
112
110 return ManifestIconDownloader::Download( 113 return ManifestIconDownloader::Download(
111 web_contents(), icon_url_, GetIdealIconSizeInPx(), 114 web_contents(), icon_url_, GetIdealIconSizeInPx(),
112 GetMinimumIconSizeInPx(), 115 GetMinimumIconSizeInPx(),
113 base::Bind(&AppBannerManager::OnAppIconFetched, GetWeakPtr())); 116 base::Bind(&AppBannerManager::OnAppIconFetched, GetWeakPtr()));
114 } 117 }
115 118
116 void AppBannerManagerAndroid::RequestAppBanner(const GURL& validated_url, 119 void AppBannerManagerAndroid::RequestAppBanner(const GURL& validated_url,
117 bool is_debug_mode) { 120 bool is_debug_mode) {
118 JNIEnv* env = base::android::AttachCurrentThread(); 121 JNIEnv* env = base::android::AttachCurrentThread();
119 if (!Java_AppBannerManager_isEnabledForTab(env, java_banner_manager_)) 122 if (!Java_AppBannerManager_isEnabledForTab(env, java_banner_manager_))
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 } 328 }
326 329
327 // static 330 // static
328 void SetTotalEngagementToTrigger(JNIEnv* env, 331 void SetTotalEngagementToTrigger(JNIEnv* env,
329 const JavaParamRef<jclass>& clazz, 332 const JavaParamRef<jclass>& clazz,
330 jdouble engagement) { 333 jdouble engagement) {
331 AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement); 334 AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement);
332 } 335 }
333 336
334 } // namespace banners 337 } // namespace banners
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698