Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2620613006: Check if a PWA is installed before checking the service worker and icon. (Closed)
Patch Set: Add missing enum value Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 4301ca903b99a83454f3f12ed044240079ad72e3..be43a915fbb21c84a08228aa77b0bf712d7976d4 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -104,6 +104,11 @@ class AppBannerManager : public content::WebContentsObserver,
explicit AppBannerManager(content::WebContents* web_contents);
~AppBannerManager() override;
+ // Returns true if the banner should be shown. Returns false if the banner has
+ // been shown too recently, or if the app has already been installed.
+ // GetAppIdentifier() must return a valid value for this method to work.
+ bool CheckIfShouldShowBanner();
+
// Return a string identifying this app for metrics.
virtual std::string GetAppIdentifier();
@@ -221,9 +226,6 @@ class AppBannerManager : public content::WebContentsObserver,
// platform-specific.
virtual void ShowBanner() = 0;
- // Returns true if the banner should be shown.
- bool CheckIfShouldShowBanner();
-
// Called after the manager sends a message to the renderer regarding its
// intention to show a prompt. The renderer will send a message back with the
// opportunity to cancel.
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698