Add getGlobalPolicy to networkingPrivate API.

extensions/browser/api/networking_private/networking_private_api.cc

Index: extensions/browser/api/networking_private/networking_private_api.cc
diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc
index d8f30697ba3ad6182cd15781b0ece92e1d05b914..7464a45b1567e514bc841e7d2914a59ff1caa2aa 100644
--- a/extensions/browser/api/networking_private/networking_private_api.cc
+++ b/extensions/browser/api/networking_private/networking_private_api.cc
@@ -779,4 +779,22 @@ void NetworkingPrivateSetCellularSimStateFunction::Failure(
   SendResponse(false);
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateGetGlobalPolicyFunction
+
+NetworkingPrivateGetGlobalPolicyFunction::
+    ~NetworkingPrivateGetGlobalPolicyFunction() {}
+
+ExtensionFunction::ResponseAction
+NetworkingPrivateGetGlobalPolicyFunction::Run() {
+  std::unique_ptr<base::DictionaryValue> policy_dict(
+      GetDelegate(browser_context())->GetGlobalPolicy());
+  DCHECK(policy_dict);
+  // private_api::GlobalPolicy is a subset of the global policy dictionary

[tbarzic, 2017/01/06 22:43:17]

I think explicitly setting |policy| properties might be better here
(mainly so there's no dependency on internals of GlobalPolicy::FromValue), but I
could live with this.

[stevenjb, 2017/01/09 19:30:37]

That would effectively be duplicating the code in GlobalPolicy::FromValue, and
would have to be kept in sync. This way if we add a new policy, we can just add
it to the IDL.

+  // (by definition), so use the api setter/getter to generate the subset.
+  std::unique_ptr<private_api::GlobalPolicy> policy(
+      private_api::GlobalPolicy::FromValue(*policy_dict.get()));

[tbarzic, 2017/01/06 22:43:17]

nit: .get() should not be needed.

[stevenjb, 2017/01/09 19:30:37]

Done.

+  return RespondNow(OneArgument(policy->ToValue()));

[tbarzic, 2017/01/06 22:43:17]

suggestion:
RespondNow(ArgumentList(
    private_api::GetGlobalPolicy::Results::Create(*policy)));

[stevenjb, 2017/01/09 19:30:37]

Done.

+}
+
 }  // namespace extensions