Add getGlobalPolicy to networkingPrivate API.

extensions/browser/api/networking_private/networking_private_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/networking_private/networking_private_api.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 761 matching lines @@
 void NetworkingPrivateSetCellularSimStateFunction::Success() {
   SendResponse(true);
 }
 
 void NetworkingPrivateSetCellularSimStateFunction::Failure(
     const std::string& error) {
   error_ = error;
   SendResponse(false);
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateGetGlobalPolicyFunction
+
+NetworkingPrivateGetGlobalPolicyFunction::
+    ~NetworkingPrivateGetGlobalPolicyFunction() {}
+
+ExtensionFunction::ResponseAction
+NetworkingPrivateGetGlobalPolicyFunction::Run() {
+  std::unique_ptr<base::DictionaryValue> policy_dict(
+      GetDelegate(browser_context())->GetGlobalPolicy());
+  DCHECK(policy_dict);
+  // private_api::GlobalPolicy is a subset of the global policy dictionary

[tbarzic, 2017/01/06 22:43:17]

I think explicitly setting |policy| properties might be better here
(mainly so there's no dependency on internals of GlobalPolicy::FromValue), but I
could live with this.

[stevenjb, 2017/01/09 19:30:37]

That would effectively be duplicating the code in GlobalPolicy::FromValue, and
would have to be kept in sync. This way if we add a new policy, we can just add
it to the IDL.

+  // (by definition), so use the api setter/getter to generate the subset.
+  std::unique_ptr<private_api::GlobalPolicy> policy(
+      private_api::GlobalPolicy::FromValue(*policy_dict.get()));

[tbarzic, 2017/01/06 22:43:17]

nit: .get() should not be needed.

[stevenjb, 2017/01/09 19:30:37]

Done.

+  return RespondNow(OneArgument(policy->ToValue()));

[tbarzic, 2017/01/06 22:43:17]

suggestion:
RespondNow(ArgumentList(
    private_api::GetGlobalPolicy::Results::Create(*policy)));

[stevenjb, 2017/01/09 19:30:37]

Done.

+}
+
 }  // namespace extensions