Add getGlobalPolicy to networkingPrivate API.

extensions/browser/api/networking_private/networking_private_chromeos.cc

Index: extensions/browser/api/networking_private/networking_private_chromeos.cc
diff --git a/extensions/browser/api/networking_private/networking_private_chromeos.cc b/extensions/browser/api/networking_private/networking_private_chromeos.cc
index 0e2e6d7671ed2d2ff7135b53e5c9495c1832f746..9e5f0c3208c48fc0967a7712463e6f7838690ebb 100644
--- a/extensions/browser/api/networking_private/networking_private_chromeos.cc
+++ b/extensions/browser/api/networking_private/networking_private_chromeos.cc
@@ -673,6 +673,17 @@ NetworkingPrivateChromeOS::GetDeviceStateList() {
   return device_state_list;
 }
 
+std::unique_ptr<base::DictionaryValue>
+NetworkingPrivateChromeOS::GetGlobalPolicy() {
+  auto result = base::MakeUnique<base::DictionaryValue>();
+  const base::DictionaryValue* global_network_config =
+      GetManagedConfigurationHandler()->GetGlobalConfigFromPolicy(

[tbarzic, 2017/01/06 22:43:18]

Why not return |global_network_config directly| and use that dict to create API
method result (to avoid creating extra copy of the dict)?

[stevenjb, 2017/01/09 19:30:37]

GetGlobalConfigFromPolicy returns a const*, so we have to do a deep copy anyway.
This way we don't have to handle null results in
NetworkingPrivateGetGlobalPolicyFunction::Run.

[tbarzic, 2017/01/09 20:24:30]

Wouldn't something like the following avoid this extra copy:
{
  const base::DictionaryValue* policy_value = GetGlobalPolicy();
  private_api::GlobalPolicy global_policy;
  if (policy_value) {
    if (!private_api::GlobalPolicy::Populate(*policy_value, &global_policy))
      LOG(ERROR) << "Failed to parse policy";
  }
  return RespondNow(ArgumentList(
      private_api::GetGlobalPolicy::Results::Create(global_policy)));
}

either way, up to you.

[stevenjb, 2017/01/09 20:43:34]

We can't call RespondNow from the delegate, and I would prefer not to introduce
additional dependencies on the API details to the delegae (i.e. by returning
std::unique_ptr<GlobalPolicy>) even if it means an extra copy here (relatively
trivial all things considered).

[tbarzic, 2017/01/09 21:11:07]

That snippet would be networking_private_api.cc code in case the delegate just
returned GetManagedConfigurationHandler()->GetGlobalConfigFromPolicy(); (and the
non Chrome OS delegate could just return nullptr).

+          std::string() /* no username hash, device policy */);
+  if (global_network_config)
+    result->MergeDictionary(global_network_config);
+  return result;
+}
+
 bool NetworkingPrivateChromeOS::EnableNetworkType(const std::string& type) {
   NetworkTypePattern pattern =
       chromeos::onc::NetworkTypePatternFromOncType(type);