Tie VR omnibox to page load progress through TabObserver.

Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620383007
Cr-Commit-Position: refs/heads/master@{#443389}
Committed: https://chromium.googlesource.com/chromium/src/+/5f298498d0bc01765cec4bbd323e2d55f7609b35

[cjgrant, 2017-01-12 19:13:00]

Description was changed from

==========
Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
==========

to

==========
Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-01-12 19:13:47]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[cjgrant, 2017-01-12 19:16:49]

https://codereview.chromium.org/2620383007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2620383007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:142:
mVrShell.onLoadProgressChanged((double) progress / 100.0);
For clarity:
- progress is a double original (WebContents, etc).
- Tab/TabObserver makes it an int for some reason.
- I'm returning it to a double here, as I hope to bypass TabObserver in the
future.

https://codereview.chromium.org/2620383007/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2620383007/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:297: this.loadProgress = 0;
Just renaming here for consistency with the observer.

[mthiesse, 2017-01-12 19:59:37]

lgtm

[cjgrant, 2017-01-12 20:05:46]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:06:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:10:37]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bshe, 2017-01-12 20:22:58]

On 2017/01/12 20:10:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
>   ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

lgtm

[cjgrant, 2017-01-12 21:19:05]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-01-12 21:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2620383007/#ps20001
(title: "Rebase to ToT.")

[commit-bot: I haz the power, 2017-01-12 21:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:39:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484255945528140,
"parent_rev": "9c0bde8a43cd39944fd13287e0192f8994619ee3", "commit_rev":
"5f298498d0bc01765cec4bbd323e2d55f7609b35"}

[commit-bot: I haz the power, 2017-01-12 22:40:10]

Description was changed from

==========
Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620383007
Cr-Commit-Position: refs/heads/master@{#443389}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f298498d0bc01765cec4bbd323e...
==========

[commit-bot: I haz the power, 2017-01-12 22:40:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f298498d0bc01765cec4bbd323e...