chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java - Issue 2620383007: Tie VR omnibox to page load progress through TabObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Issue 2620383007: Tie VR omnibox to page load progress through TabObserver. (Closed)

Patch Set: Rebase to ToT. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

index 374e6c7804555b8e54f64e3df92f01eb1ae75cc5..7a36bd41bc71ee8959c4815b44dff57685307aaf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

@@ -135,6 +135,12 @@ public class VrShellDelegate {

// TODO(mthiesse): Update the native WebContents pointer and compositor.

shutdownVR(false, mVrSupportLevel == VR_DAYDREAM /* showTransition */);

}

+ @Override

+ public void onLoadProgressChanged(Tab tab, int progress) {

+ if (!mInVr) return;

+ mVrShell.onLoadProgressChanged((double) progress / 100.0);

+ }

};

}