Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2620373005: Rename AudioInputWriter -> AudioFileWriter. (Closed)

Created:
3 years, 11 months ago by Henrik Grunell
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis, o1ka, boliu
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AudioInputWriter -> AudioFileWriter. The class is generic and will be used also for output recording. Also rename its implementation AudioInputDebugWriter -> AudioDebugFileWriter. BUG=531883 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2620373005 Cr-Commit-Position: refs/heads/master@{#443519} Committed: https://chromium.googlesource.com/chromium/src/+/5c59642a22628c20f1765d4e5f8d1f53897a720c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -824 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/renderer_host/media/audio_debug_file_writer.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/renderer_host/media/audio_debug_file_writer.cc View 9 chunks +18 lines, -16 lines 0 comments Download
A + content/browser/renderer_host/media/audio_debug_file_writer_unittest.cc View 9 chunks +26 lines, -26 lines 0 comments Download
D content/browser/renderer_host/media/audio_input_debug_writer.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/renderer_host/media/audio_input_debug_writer.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc View 1 chunk +0 lines, -350 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + media/audio/audio_file_writer.h View 3 chunks +7 lines, -7 lines 0 comments Download
M media/audio/audio_input_controller.h View 5 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_input_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D media/audio/audio_input_writer.h View 1 chunk +0 lines, -41 lines 0 comments Download
M media/audio/test_audio_input_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Henrik Grunell
3 years, 11 months ago (2017-01-12 13:24:16 UTC) #6
o1ka
lgtm
3 years, 11 months ago (2017-01-12 13:31:01 UTC) #7
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-12 19:06:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620373005/1
3 years, 11 months ago (2017-01-13 08:40:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c59642a22628c20f1765d4e5f8d1f53897a720c
3 years, 11 months ago (2017-01-13 08:45:26 UTC) #15
Wez
Hallo boliu@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 19:47:07 UTC) #17
boliu
3 years, 10 months ago (2017-02-07 21:21:06 UTC) #18
Message was sent while issue was closed.
On 2017/02/07 19:47:07, Wez wrote:
> Hallo mailto:boliu@chromium.org!
> Due to a depot_tools patch which mistakenly removed the OWNERS check for
> non-source files (see crbug.com/684270), the following files landed in this CL
> and need a retrospective review from you:
> 	content/browser/BUILD.gn
> Thanks,
> Wez

lgtm

Powered by Google App Engine
This is Rietveld 408576698