Refactor how UseCounter::SyntheticKeyframesInCompositedCSSAnimation is counted

Refactor how UseCounter::SyntheticKeyframesInCompositedCSSAnimation is counted

This patch rewrites the detection logic for composited animations that
have neutral keyframes.

The previous code was relatively expensive and failed a DCHECK when
custom properties were used. This patch moves the use counting down into
where we actually handle compositing neutral keyframes.

BUG=679994
Review-Url: https://codereview.chromium.org/2620303002
Cr-Commit-Position: refs/heads/master@{#443180}
Committed: https://chromium.googlesource.com/chromium/src/+/2d136863c16220ecc767607d4615624168d99212

[alancutter (OOO until 2018), 2017-01-11 07:31:28]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-01-12 00:44:01]

On 2017/01/11 07:31:28, alancutter wrote:

lgtm but do we want some test for the synthetic keyframe custom property case?

[alancutter (OOO until 2018), 2017-01-12 00:50:32]

On 2017/01/12 at 00:44:01, timloh wrote:
> On 2017/01/11 07:31:28, alancutter wrote:
> 
> lgtm but do we want some test for the synthetic keyframe custom property case?

Oops, yeah I should probably add the case that hits the DCHECK. :P

[alancutter (OOO until 2018), 2017-01-12 00:55:19]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-12 00:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2620303002/#ps20001
(title: "Moar testing")

[commit-bot: I haz the power, 2017-01-12 00:56:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:14:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2017-01-12 03:17:47]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-12 03:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2620303002/#ps40001
(title: "g cl set-commit")

[commit-bot: I haz the power, 2017-01-12 03:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:27:35]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[alancutter (OOO until 2018), 2017-01-12 04:32:03]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-12 04:32:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 05:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 05:38:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2017-01-12 06:59:43]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-12 06:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 07:58:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484204383547140,
"parent_rev": "c162e0c69d45b4bb191cb80ca9fde153950a270b", "commit_rev":
"2d136863c16220ecc767607d4615624168d99212"}

[commit-bot: I haz the power, 2017-01-12 07:58:56]

Description was changed from

==========
Refactor how UseCounter::SyntheticKeyframesInCompositedCSSAnimation is counted

This patch rewrites the detection logic for composited animations that
have neutral keyframes.

The previous code was relatively expensive and failed a DCHECK when
custom properties were used. This patch moves the use counting down into
where we actually handle compositing neutral keyframes.

BUG=679994
==========

to

==========
Refactor how UseCounter::SyntheticKeyframesInCompositedCSSAnimation is counted

This patch rewrites the detection logic for composited animations that
have neutral keyframes.

The previous code was relatively expensive and failed a DCHECK when
custom properties were used. This patch moves the use counting down into
where we actually handle compositing neutral keyframes.

BUG=679994

Review-Url: https://codereview.chromium.org/2620303002
Cr-Commit-Position: refs/heads/master@{#443180}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d136863c16220ecc767607d4615...
==========

[commit-bot: I haz the power, 2017-01-12 07:58:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d136863c16220ecc767607d4615...