Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2620293002: Remove CSSFontSelector argument and member from CSSSegmentedFontFace (Closed)

Created:
3 years, 11 months ago by meade_UTC10
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CSSFontSelector argument and member from CSSSegmentedFontFace The CSSFontSelector was stored just so it could be used for loading. Instead, pass in a Document when loading a font. This addresses a FIXME found in the code.

Patch Set 1 #

Patch Set 2 : Fix merge error #

Patch Set 3 : Update test #

Patch Set 4 : Revert unneccesary change #

Patch Set 5 : Get it to build again #

Patch Set 6 : Fix loading timing; update test #

Patch Set 7 : Fix formatting, add comment #

Patch Set 8 : Update test for CL comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -153 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-add-remove-while-loading.html View 1 2 3 4 5 6 7 1 chunk +75 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/fontfaceset-add-remove-while-loading-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.h View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 2 3 4 5 5 chunks +18 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h View 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp View 1 2 3 4 5 6 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceCache.h View 1 2 3 4 5 6 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceCache.cpp View 1 2 3 4 5 6 3 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 2 3 4 5 6 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 2624893003 Patch 80001

Messages

Total messages: 5 (5 generated)
meade_UTC10
The CQ bit was checked by meade@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 06:21:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620293002/1
3 years, 11 months ago (2017-01-11 06:21:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 07:51:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/361614)
3 years, 11 months ago (2017-01-11 07:51:52 UTC) #4
meade_UTC10
3 years, 7 months ago (2017-05-25 07:11:11 UTC) #5 
Description was changed from

==========
Remove CSSFontSelector argument and member from CSSSegmentedFontFace

The CSSFontSelector was stored just so it could be used for loading. Instead,
pass in a Document when loading a font.

This addresses a FIXME found in the code.
==========

to

==========
Remove CSSFontSelector argument and member from CSSSegmentedFontFace

The CSSFontSelector was stored just so it could be used for loading. Instead,
pass in a Document when loading a font.

This addresses a FIXME found in the code.
==========

Powered by Google App Engine
This is Rietveld 408576698