Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/css/FontFaceCache.h

Issue 2620293002: Remove CSSFontSelector argument and member from CSSSegmentedFontFace (Closed)
Patch Set: Update test for CL comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/FontFaceCache.h
diff --git a/third_party/WebKit/Source/core/css/FontFaceCache.h b/third_party/WebKit/Source/core/css/FontFaceCache.h
index ab0b07bdc4d047dd88d859e9d6d71c72585eb62a..549fb186a1518aaaa8853b9d582005446bcdd420 100644
--- a/third_party/WebKit/Source/core/css/FontFaceCache.h
+++ b/third_party/WebKit/Source/core/css/FontFaceCache.h
@@ -36,7 +36,6 @@
namespace blink {
class FontFace;
-class CSSFontSelector;
class CSSSegmentedFontFace;
class FontDescription;
class StyleRuleFontFace;
@@ -47,13 +46,11 @@ class FontFaceCache final {
public:
FontFaceCache();
- // FIXME: Remove CSSFontSelector as argument. Passing CSSFontSelector here is
- // a result of egregious spaghettification in FontFace/FontFaceSet.
- void add(CSSFontSelector*, const StyleRuleFontFace*, FontFace*);
+ void add(const StyleRuleFontFace*, FontFace*);
void remove(const StyleRuleFontFace*);
void clearCSSConnected();
void clearAll();
- void addFontFace(CSSFontSelector*, FontFace*, bool cssConnected);
+ void addFontFace(FontFace*, bool cssConnected);
void removeFontFace(FontFace*, bool cssConnected);
// FIXME: It's sort of weird that add/remove uses StyleRuleFontFace* as key,
« no previous file with comments | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | third_party/WebKit/Source/core/css/FontFaceCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698