Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2620193002: Revert of DevTools: move front-end URL handling to DevToolsUIBindingds (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: move front-end URL handling to DevToolsUIBindingds (patchset #2 id:40001 of https://codereview.chromium.org/2607833002/ ) Reason for revert: A better fix is coming, reverting this one to make it a part of the new fix so that one CL may be merged onto a branch. Original issue's description: > DevTools: move front-end URL handling to DevToolsUIBindingds > > BUG=662859 > > Committed: https://crrev.com/eea3300239f0b53e172a320eb8de59d0bea65f27 > Cr-Commit-Position: refs/heads/master@{#440926} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662859 Review-Url: https://codereview.chromium.org/2620193002 Cr-Commit-Position: refs/heads/master@{#442758} Committed: https://chromium.googlesource.com/chromium/src/+/714ce74842af647ab192124910b08a07ee7d606b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -296 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 10 chunks +10 lines, -157 lines 0 comments Download
D chrome/browser/devtools/devtools_ui_bindings_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/devtools/url_constants.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/devtools/url_constants.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 5 chunks +148 lines, -7 lines 0 comments Download
A chrome/browser/ui/webui/devtools_ui_unittest.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
caseq
Created Revert of DevTools: move front-end URL handling to DevToolsUIBindingds
3 years, 11 months ago (2017-01-10 23:58:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620193002/1
3 years, 11 months ago (2017-01-10 23:59:10 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:31:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/714ce74842af647ab192124910b0...

Powered by Google App Engine
This is Rietveld 408576698