Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2607833002: DevTools: move front-end URL handling to DevToolsUIBindingds (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move front-end URL handling to DevToolsUIBindingds BUG=662859 Committed: https://crrev.com/eea3300239f0b53e172a320eb8de59d0bea65f27 Cr-Commit-Position: refs/heads/master@{#440926}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -271 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 10 chunks +157 lines, -10 lines 0 comments Download
A + chrome/browser/devtools/devtools_ui_bindings_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/devtools/url_constants.h View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/devtools/url_constants.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 5 chunks +7 lines, -148 lines 0 comments Download
D chrome/browser/ui/webui/devtools_ui_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
caseq
3 years, 11 months ago (2016-12-28 23:05:45 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2607833002/diff/20001/chrome/browser/devtools/devtools_ui_bindings.cc File chrome/browser/devtools/devtools_ui_bindings.cc (right): https://codereview.chromium.org/2607833002/diff/20001/chrome/browser/devtools/devtools_ui_bindings.cc#newcode1015 chrome/browser/devtools/devtools_ui_bindings.cc:1015: NOTREACHED(); This could actually happen, because navigation is ...
3 years, 11 months ago (2016-12-29 01:16:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607833002/40001
3 years, 11 months ago (2016-12-29 01:19:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
3 years, 11 months ago (2016-12-29 02:19:48 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eea3300239f0b53e172a320eb8de59d0bea65f27 Cr-Commit-Position: refs/heads/master@{#440926}
3 years, 11 months ago (2017-01-02 15:51:27 UTC) #16
caseq
3 years, 11 months ago (2017-01-10 23:58:10 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2620193002/ by caseq@chromium.org.

The reason for reverting is: A better fix is coming, reverting this one to make
it a part of the new fix so that one CL may be merged onto a branch..

Powered by Google App Engine
This is Rietveld 408576698