Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2619603002: Remove android_java_ui as it is not used (Closed)

Created:
3 years, 11 months ago by F
Modified:
3 years, 11 months ago
CC:
asanka, asvitkine+watch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chasej+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, darin-cc_chromium.org, dbeam+watch-history_chromium.org, devtools-reviews_chromium.org, Patrick Dubroy, estade+watch_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, harkness+watch_chromium.org, iclelland+watch_chromium.org, jam, jkarlin+watch_chromium.org, johnme+watch_chromium.org, loading-reviews+metrics_chromium.org, loading-reviews_chromium.org, markusheintz_, mathp+autofillwatch_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-permissions_chromium.org, mmenke, msramek+watch_chromium.org, Michael van Ouwerkerk, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, pam+watch_chromium.org, Peter Beverloo, pfeldman, raymes+watch_chromium.org, Randy Smith (Not in Mondays), rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, sync-reviews_chromium.org, Ted C, tfarina, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_java_ui as it is not used BUG=651266 Review-Url: https://codereview.chromium.org/2619603002 Cr-Commit-Position: refs/heads/master@{#442623} Committed: https://chromium.googlesource.com/chromium/src/+/db4a58e8a28b235e0293ca440d6056e3cd957608

Patch Set 1 #

Total comments: 30

Patch Set 2 : Addressing comments #

Patch Set 3 : Rebase to master #

Patch Set 4 : Manual rebase TT #

Patch Set 5 : Another rebase to master #

Total comments: 2

Patch Set 6 : Addressing comments & fix rebase #

Patch Set 7 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1370 lines, -1640 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 4 5 6 3 chunks +33 lines, -43 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 4 5 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 chunks +401 lines, -411 lines 0 comments Download
M chrome/browser/android/devtools_manager_delegate_android.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/background_sync/background_sync_controller_impl_unittest.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 2 3 4 5 6 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_factory.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 1 2 3 4 5 6 8 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 10 chunks +21 lines, -36 lines 0 comments Download
M chrome/browser/dom_distiller/profile_utils.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/download/download_resource_throttle_unittest.cc View 1 6 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 19 chunks +182 lines, -186 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 29 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/history/chrome_history_backend_client.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/io_thread.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/media/router/media_router_dialog_controller.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media/router/media_router_dialog_controller_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc View 1 10 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 8 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper_unittest.cc View 1 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 2 8 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 4 chunks +328 lines, -486 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.cc View 1 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper_unittest.cc View 1 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_notification_manager.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/signin/chrome_signin_helper.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service_factory.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/speech/tts_android.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 3 chunks +131 lines, -133 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 8 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/ui/autofill/credit_card_scanner_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/net_export_ui.cc View 1 2 3 4 5 6 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/features.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 46 (32 generated)
F
Hi Alexandre, PTAL. Thanks!
3 years, 11 months ago (2017-01-06 21:41:53 UTC) #6
aelias_OOO_until_Jul13
lgtm, adding sky@ for chrome/ OWNERS
3 years, 11 months ago (2017-01-06 21:50:59 UTC) #8
Ted C
couple things I spotted looks like they could be combined...didn't get through it all though ...
3 years, 11 months ago (2017-01-06 22:00:21 UTC) #10
Ted C
https://codereview.chromium.org/2619603002/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/2619603002/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode268 chrome/browser/chrome_content_browser_client.cc:268: #if defined(OS_ANDROID) combine with above https://codereview.chromium.org/2619603002/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode709 chrome/browser/chrome_content_browser_client.cc:709: #if defined(OS_ANDROID) ...
3 years, 11 months ago (2017-01-06 22:33:30 UTC) #11
sky
LGTM https://codereview.chromium.org/2619603002/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (left): https://codereview.chromium.org/2619603002/diff/1/chrome/browser/BUILD.gn#oldcode2481 chrome/browser/BUILD.gn:2481: "chrome_browser_field_trials_mobile.cc", Ugh. This is too hard to review. ...
3 years, 11 months ago (2017-01-06 23:27:27 UTC) #12
F
Thanks Alexandre, Scott, and Ted, for the detailed review! PTAL Hi Tim, PTAL. Thanks! https://codereview.chromium.org/2619603002/diff/1/chrome/android/BUILD.gn ...
3 years, 11 months ago (2017-01-09 21:36:33 UTC) #29
Ted C
lgtm https://codereview.chromium.org/2619603002/diff/80001/chrome/app/chrome_main_delegate.cc File chrome/app/chrome_main_delegate.cc (right): https://codereview.chromium.org/2619603002/diff/80001/chrome/app/chrome_main_delegate.cc#newcode889 chrome/app/chrome_main_delegate.cc:889: #if defined(OS_ANDROID) just realized this is within a ...
3 years, 11 months ago (2017-01-09 21:49:46 UTC) #30
tsergeant
browsing_history_handler lgtm
3 years, 11 months ago (2017-01-09 22:39:03 UTC) #33
sky
SLGTM
3 years, 11 months ago (2017-01-09 22:51:54 UTC) #34
F
Thanks Alexandre, Scott, Ted, and Tim! PTAL I'm going to make a submit attempt https://codereview.chromium.org/2619603002/diff/80001/chrome/app/chrome_main_delegate.cc ...
3 years, 11 months ago (2017-01-09 23:50:43 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619603002/100001
3 years, 11 months ago (2017-01-09 23:51:47 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/344820)
3 years, 11 months ago (2017-01-10 00:43:55 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619603002/120001
3 years, 11 months ago (2017-01-10 16:07:50 UTC) #43
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:41:12 UTC) #46
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/db4a58e8a28b235e0293ca440d60...

Powered by Google App Engine
This is Rietveld 408576698