Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/app/chrome_main_delegate.cc

Issue 2619603002: Remove android_java_ui as it is not used (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_main_delegate.h" 5 #include "chrome/app/chrome_main_delegate.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_paths.h" 10 #include "base/base_paths.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 #endif 94 #endif
95 95
96 #if defined(OS_CHROMEOS) 96 #if defined(OS_CHROMEOS)
97 #include "base/sys_info.h" 97 #include "base/sys_info.h"
98 #include "chrome/browser/chromeos/boot_times_recorder.h" 98 #include "chrome/browser/chromeos/boot_times_recorder.h"
99 #include "chromeos/chromeos_paths.h" 99 #include "chromeos/chromeos_paths.h"
100 #include "chromeos/chromeos_switches.h" 100 #include "chromeos/chromeos_switches.h"
101 #include "chromeos/hugepage_text/hugepage_text.h" 101 #include "chromeos/hugepage_text/hugepage_text.h"
102 #endif 102 #endif
103 103
104 #if BUILDFLAG(ANDROID_JAVA_UI) 104 #if defined(OS_ANDROID)
Ted C 2017/01/06 22:00:21 combine with below
F 2017/01/09 21:36:32 Done.
105 #include "chrome/browser/android/java_exception_reporter.h" 105 #include "chrome/browser/android/java_exception_reporter.h"
106 #endif 106 #endif
107 107
108 #if defined(OS_ANDROID) 108 #if defined(OS_ANDROID)
109 #include "chrome/common/descriptors_android.h" 109 #include "chrome/common/descriptors_android.h"
110 #else 110 #else
111 // Diagnostics is only available on non-android platforms. 111 // Diagnostics is only available on non-android platforms.
112 #include "chrome/browser/diagnostics/diagnostics_controller.h" 112 #include "chrome/browser/diagnostics/diagnostics_controller.h"
113 #include "chrome/browser/diagnostics/diagnostics_writer.h" 113 #include "chrome/browser/diagnostics/diagnostics_writer.h"
114 #endif 114 #endif
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 882
883 chrome::InitializePDF(); 883 chrome::InitializePDF();
884 #endif 884 #endif
885 885
886 #if defined(OS_POSIX) && !defined(OS_MACOSX) 886 #if defined(OS_POSIX) && !defined(OS_MACOSX)
887 // Zygote needs to call InitCrashReporter() in RunZygote(). 887 // Zygote needs to call InitCrashReporter() in RunZygote().
888 if (process_type != switches::kZygoteProcess) { 888 if (process_type != switches::kZygoteProcess) {
889 #if defined(OS_ANDROID) 889 #if defined(OS_ANDROID)
890 if (process_type.empty()) { 890 if (process_type.empty()) {
891 breakpad::InitCrashReporter(process_type); 891 breakpad::InitCrashReporter(process_type);
892 // TODO(crbug.com/551176): Exception reporting should work without 892 // TODO(crbug.com/551176): Exception reporting should work without OS_ANDROID.
Ted C 2017/01/06 22:00:21 Remove as this is no longer valid
F 2017/01/09 21:36:32 Done.
893 // ANDROID_JAVA_UI 893 #if defined(OS_ANDROID)
894 #if BUILDFLAG(ANDROID_JAVA_UI)
895 chrome::android::InitJavaExceptionReporter(); 894 chrome::android::InitJavaExceptionReporter();
896 #endif 895 #endif
897 } else { 896 } else {
898 breakpad::InitNonBrowserCrashReporterForAndroid(process_type); 897 breakpad::InitNonBrowserCrashReporterForAndroid(process_type);
899 } 898 }
900 #else // !defined(OS_ANDROID) 899 #else // !defined(OS_ANDROID)
901 breakpad::InitCrashReporter(process_type); 900 breakpad::InitCrashReporter(process_type);
902 #endif // defined(OS_ANDROID) 901 #endif // defined(OS_ANDROID)
903 } 902 }
904 #endif // defined(OS_POSIX) && !defined(OS_MACOSX) 903 #endif // defined(OS_POSIX) && !defined(OS_MACOSX)
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 case version_info::Channel::CANARY: 1084 case version_info::Channel::CANARY:
1086 return true; 1085 return true;
1087 case version_info::Channel::DEV: 1086 case version_info::Channel::DEV:
1088 case version_info::Channel::BETA: 1087 case version_info::Channel::BETA:
1089 case version_info::Channel::STABLE: 1088 case version_info::Channel::STABLE:
1090 default: 1089 default:
1091 // Don't enable instrumentation. 1090 // Don't enable instrumentation.
1092 return false; 1091 return false;
1093 } 1092 }
1094 } 1093 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698