Avoid overriding methods from both blink and non-blink at once.

Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of
the concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
Review-Url: https://codereview.chromium.org/2619593002
Cr-Commit-Position: refs/heads/master@{#442052}
Committed: https://chromium.googlesource.com/chromium/src/+/4f1fd6a03a5d4d6299dfd02cc8485b42720d1e08

[danakj, 2017-01-06 18:11:18]

Description was changed from

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither methods is ever used as part of the
RendererMediaPlayerInterface, only paused() is used as part of the
concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

to

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither methods is ever used as part of the
RendererMediaPlayerInterface, only paused() is used as part of the
concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

[danakj, 2017-01-06 18:11:18]

danakj@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[danakj, 2017-01-06 18:11:44]

Description was changed from

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither methods is ever used as part of the
RendererMediaPlayerInterface, only paused() is used as part of the
concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

to

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of the
concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

[danakj, 2017-01-06 18:11:54]

Description was changed from

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of the
concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

to

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of
the concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

[danakj, 2017-01-06 18:30:55]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-01-06 18:35:26]

lgtm

[danakj, 2017-01-06 18:44:06]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-01-06 18:44:10]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:44:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:15:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483728250392440, "parent_rev":
"d6f9158ff62fff689993067c3273ccb7beecbc16", "commit_rev":
"4f1fd6a03a5d4d6299dfd02cc8485b42720d1e08"}

[commit-bot: I haz the power, 2017-01-06 21:15:53]

Description was changed from

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of
the concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344
==========

to

==========
Avoid overriding methods from both blink and non-blink at once.

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of
the concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344

Review-Url: https://codereview.chromium.org/2619593002
Cr-Commit-Position: refs/heads/master@{#442052}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f1fd6a03a5d4d6299dfd02cc848...
==========

[commit-bot: I haz the power, 2017-01-06 21:15:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f1fd6a03a5d4d6299dfd02cc848...