Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: media/blink/webmediaplayer_cast_android.h

Issue 2619593002: Avoid overriding methods from both blink and non-blink at once. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/renderer_media_player_interface.h ('k') | media/blink/webmediaplayer_cast_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_cast_android.h
diff --git a/media/blink/webmediaplayer_cast_android.h b/media/blink/webmediaplayer_cast_android.h
index 3a82b948496258306ace7c3df3fcc4033636fb13..ff94c167d923800a61c3ee916d23abb99d229a69 100644
--- a/media/blink/webmediaplayer_cast_android.h
+++ b/media/blink/webmediaplayer_cast_android.h
@@ -45,6 +45,7 @@ class WebMediaPlayerCast : public RendererMediaPlayerInterface {
void SetMediaPlayerManager(
RendererMediaPlayerManagerInterface* media_player_manager);
bool isRemote() const { return is_remote_; }
+ bool IsPaused() const { return paused_; }
double currentTime() const;
void play();
@@ -82,20 +83,11 @@ class WebMediaPlayerCast : public RendererMediaPlayerInterface {
void OnRemoteRouteAvailabilityChanged(
blink::WebRemotePlaybackAvailability availability) override;
- // Getters of playback state.
- // bool paused() const override;
-
- // True if the loaded media has a playable video track.
- // bool hasVideo() const override;
-
// This function is called by the RendererMediaPlayerManager to pause the
// video and release the media player and surface texture when we switch tabs.
// However, the actual GlTexture is not released to keep the video screenshot.
void SuspendAndReleaseResources() override;
- bool paused() const override;
- bool hasVideo() const override;
-
void SetDeviceScaleFactor(float scale_factor);
scoped_refptr<VideoFrame> GetCastingBanner();
void setPoster(const blink::WebURL& poster);
« no previous file with comments | « media/blink/renderer_media_player_interface.h ('k') | media/blink/webmediaplayer_cast_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698