Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy …

Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy when tcmalloc is available.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ff7ee61326b856c4552634cf6808112c9a1b820

[bkonyi, 2017-01-05 23:29:04]

bkonyi@google.com changed reviewers:
+ zra@google.com

[bkonyi, 2017-01-05 23:29:05]

This is what I have so far for the MallocHooks stubs. Can you give it a quick
look and let me know if everything looks alright?

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode64
runtime/vm/vm.gypi:64: ['OS == "linux" and asan == 0 and msan == 0 and tsan ==
0', {
There was already a rule for 'OS == "linux' so I added a separate condition for
the tcmalloc dependency inclusion. Let me know if this isn't right. Also, I'll
fix the indentation during my next patch.

[zra, 2017-01-06 16:13:17]

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:5: #ifdef DART_USE_TCMALLOC
nit: We tend to use "#if defined(DART_USE_TCMALLOC)"

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:16: #endif
Missing whitespace before this line. Also should say:

#endif  // defined(DART_USE_TCMALLOC)

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
File runtime/vm/malloc_hooks_unsupported.cc (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
runtime/vm/malloc_hooks_unsupported.cc:5: #ifndef DART_USE_TCMALLOC
#if !defined(DART_USE_TCMALLOC)

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
runtime/vm/malloc_hooks_unsupported.cc:16: #endif
Missing newline and // !defined(DART_USE_TCMALLOC)

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode66
runtime/vm/vm.gypi:66: '../third_party/tcmalloc/tcmalloc.gypi:tcmalloc',
I think it's not necessary to add the dependence on tcmalloc here. Instead maybe
just add a comment that the condition should be kept in sync with where we're
already adding the dependence. Normally we'd figure out how to add a variable
somewhere to keep them from going out of sync, but since gyp is going away soon
it's probably not worth spending time out.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode117
runtime/vm/vm.gypi:117: 'dependencies': [
ditto

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode169
runtime/vm/vm.gypi:169: 'dependencies': [
ditto

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode222
runtime/vm/vm.gypi:222: 'dependencies': [
ditto

[bkonyi, 2017-01-06 20:23:35]

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:5: #ifdef DART_USE_TCMALLOC
On 2017/01/06 at 16:13:17, zra wrote:
> nit: We tend to use "#if defined(DART_USE_TCMALLOC)"

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:16: #endif
On 2017/01/06 at 16:13:17, zra wrote:
> Missing whitespace before this line. Also should say:
> 
> #endif  // defined(DART_USE_TCMALLOC)

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
File runtime/vm/malloc_hooks_unsupported.cc (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
runtime/vm/malloc_hooks_unsupported.cc:5: #ifndef DART_USE_TCMALLOC
On 2017/01/06 at 16:13:17, zra wrote:
> #if !defined(DART_USE_TCMALLOC)

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/malloc_hooks_uns...
runtime/vm/malloc_hooks_unsupported.cc:16: #endif
On 2017/01/06 at 16:13:17, zra wrote:
> Missing newline and // !defined(DART_USE_TCMALLOC)

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode66
runtime/vm/vm.gypi:66: '../third_party/tcmalloc/tcmalloc.gypi:tcmalloc',
On 2017/01/06 at 16:13:17, zra wrote:
> I think it's not necessary to add the dependence on tcmalloc here. Instead
maybe just add a comment that the condition should be kept in sync with where
we're already adding the dependence. Normally we'd figure out how to add a
variable somewhere to keep them from going out of sync, but since gyp is going
away soon it's probably not worth spending time out.

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode117
runtime/vm/vm.gypi:117: 'dependencies': [
On 2017/01/06 at 16:13:17, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode169
runtime/vm/vm.gypi:169: 'dependencies': [
On 2017/01/06 at 16:13:17, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2619443002/diff/1/runtime/vm/vm.gypi#newcode222
runtime/vm/vm.gypi:222: 'dependencies': [
On 2017/01/06 at 16:13:17, zra wrote:
> ditto

Done.

[zra, 2017-01-06 20:33:17]

lgtm

[bkonyi, 2017-01-06 20:38:31]

Description was changed from

==========
Created placeholders for MallocHooks implementation and added define
DART_USE_TCMALLOC to specifiy when tcmalloc is available.

BUG=
==========

to

==========
Created placeholders for MallocHooks implementation and added define
DART_USE_TCMALLOC to specifiy when tcmalloc is available.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ff7ee61326b856c4552634cf6808112c9a1b820
==========

[bkonyi, 2017-01-06 20:38:32]

Committed patchset #2 (id:20001) manually as
9ff7ee61326b856c4552634cf6808112c9a1b820 (presubmit successful).