runtime/vm/malloc_hooks.cc - Issue 2619443002: Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/malloc_hooks.cc

Issue 2619443002: Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy … (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #ifdef DART_USE_TCMALLOC
	zra 2017/01/06 16:13:17 nit: We tend to use "#if defined(DART_USE_TCMALLOC nit: We tend to use "#if defined(DART_USE_TCMALLOC)" bkonyi 2017/01/06 20:23:34 Done. Show quoted text On 2017/01/06 at 16:13:17, zra wrote: > nit: We tend to use "#if defined(DART_USE_TCMALLOC)" Done.
	6

	7 #include "vm/malloc_hooks.h"

	8

	9 namespace dart {

	10

	11 void MallocHooks::Init() {

	12 // TODO(bkonyi): Implement

	13 }

	14

	15 } // namespace dart

	16 #endif
	zra 2017/01/06 16:13:17 Missing whitespace before this line. Also should s Missing whitespace before this line. Also should say: #endif // defined(DART_USE_TCMALLOC) bkonyi 2017/01/06 20:23:34 Done. Show quoted text On 2017/01/06 at 16:13:17, zra wrote: > Missing whitespace before this line. Also should say: > > #endif // defined(DART_USE_TCMALLOC) Done.
OLD	NEW