Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: runtime/bin/BUILD.gn

Issue 2619443002: Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy … (Closed)
Patch Set: Removed extra dependencies and corrected some code style issues. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index a377332a4a1bd5ce738627bd342a0c9dcfd2ff39..856f8e68c0d41434bdcfabb8cc90d46f42c700c2 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -3,27 +3,7 @@
# BSD-style license that can be found in the LICENSE file.
import("gypi_contents.gni")
-
-declare_args() {
- # Whether to fall back to built-in root certificates when they cannot be
- # verified at the operating system level.
- dart_use_fallback_root_certificates = false
-
- # The BUILD.gn file that we pull from chromium as part of zlib has a
- # dependence on //base, which we don't pull in. In a standalone build of the
- # VM, we set this to //runtime/bin/zlib where we have a BUILD.gn file without
- # a dependence on //base.
- dart_zlib_path = "//third_party/zlib"
-
- # Whether to link the standalone VM against tcmalloc. The standalone build of
- # the VM enables this only for Linux builds.
- dart_use_tcmalloc = false
-}
-
-# TODO(zra): Remove this when Fuchsia has a root cert cache on the filesystem.
-if (defined(is_fuchsia) && is_fuchsia) {
- dart_use_fallback_root_certificates = true
-}
+import("../runtime_args.gni")
# Generate a resources.cc file for the service isolate without Observatory.
action("gen_resources_cc") {
@@ -590,12 +570,13 @@ template("dart_executable") {
"$dart_zlib_path",
] + extra_deps
+ defines = extra_defines
+
if (dart_use_tcmalloc) {
deps += [ "//third_party/tcmalloc" ]
+ defines += [ "DART_USE_TCMALLOC" ]
}
- defines = extra_defines
-
sources = [
"main.cc",
"vmservice_impl.cc",
@@ -810,6 +791,7 @@ executable("run_vm_tests") {
if (dart_use_tcmalloc) {
deps += [ "//third_party/tcmalloc" ]
+ defines += [ "DART_USE_TCMALLOC" ]
}
# The VM sources are already included in libdart, so we just want to add in
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698