Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2619393002: Rewrite how paint properties are built with bg:fixed main thread scrolling (Closed)

Created:
3 years, 11 months ago by pdr.
Modified:
3 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite how paint properties are built with bg:fixed main thread scrolling Background-attachment: fixed forces main thread scrolling. The initial paint property implementation [1] incorrectly allowed subtrees to scroll off the main thread when an ancestor forced main thread scrolling reasons. If there are three nested frames (A->B->C) and B has bg: fixed objects, both B and C should have main thread reasons set (in [1], A and B would). This patch also removes support for non-frame scrollers to change main thread scrolling reasons for bg: fixed so that spv1 and spv2 match. [1] https://chromium.googlesource.com/chromium/src/+/3797c08066b335c81847266d1f16dafc9b21e886 BUG=664672 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2619393002 Cr-Commit-Position: refs/heads/master@{#442413} Committed: https://chromium.googlesource.com/chromium/src/+/0f8b383bba59a8240c646a99fb0a5b2afc995d5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -37 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 7 chunks +44 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp View 2 chunks +80 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pdr.
3 years, 11 months ago (2017-01-09 19:43:18 UTC) #3
chrishtr
lgtm
3 years, 11 months ago (2017-01-09 23:37:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619393002/1
3 years, 11 months ago (2017-01-09 23:38:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 00:19:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f8b383bba59a8240c646a99fb0a...

Powered by Google App Engine
This is Rietveld 408576698