third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2619393002: Rewrite how paint properties are built with bg:fixed main thread scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2619393002: Rewrite how paint properties are built with bg:fixed main thread scrolling (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index b1c63fa09a9a0f0b828fb93bc29349eee8856b2c..76339c18e9f23969b9a83b58501c3c737cf9be1a 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -2873,10 +2873,8 @@ TEST_P(PaintPropertyTreeBuilderTest, MainThreadScrollReasonsWithoutScrolling) {

"<div class='forceScroll'></div>");

Element* overflow = document().getElementById("overflow");

EXPECT_TRUE(frameScroll()->hasBackgroundAttachmentFixedDescendants());

- EXPECT_TRUE(overflow->layoutObject()

- ->paintProperties()

- ->scroll()

- ->hasBackgroundAttachmentFixedDescendants());

+ // No scroll node is needed.

+ EXPECT_EQ(overflow->layoutObject()->paintProperties()->scroll(), nullptr);

}

TEST_P(PaintPropertyTreeBuilderTest, PaintOffsetsUnderMultiColumn) {