Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2619203006: Adjust memory sizes of persistent histogram allocations. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Adjust memory sizes of persistent histogram allocations. Most subprocesses have very few histograms and so use little of the memory they are given. 64KiB is a typical minimum allocation, though. Browser histogram memory usage has increased now that subprocess histograms are fully merged into the main process. BUG=675600 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2604433002 Cr-Commit-Position: refs/heads/master@{#441688} (cherry picked from commit 867f4553745f6106db762b4260397740760aaacf) Review-Url: https://codereview.chromium.org/2619203006 . Cr-Commit-Position: refs/branch-heads/2924@{#714} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/7867c40c4e436908620049ee2311f9a8591a47fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
bcwhite
Committed patchset #1 (id:1) manually as 7867c40c4e436908620049ee2311f9a8591a47fe.
3 years, 11 months ago (2017-01-10 15:29:52 UTC) #2
jochen (gone - plz use gerrit)
please don't TBR patches like this in the future patches that are Ok to be ...
3 years, 11 months ago (2017-01-10 15:34:24 UTC) #3
chromium-reviews
Are you referring to the beta CL or the original HEAD CL? I didn't specifically ...
3 years, 11 months ago (2017-01-10 18:05:36 UTC) #4
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-11 15:18:23 UTC) #5
Message was sent while issue was closed.
sorry for the confusion - the merge to branch is ok to TBR.

For the original message, please don't TBR outside of the (narrow)
exceptions - if it takes too long to get an review, please make sure to
bring this to the attention of e.g. the owners one level up

On Tue, Jan 10, 2017 at 7:05 PM Brian White <bcwhite@google.com> wrote:

> Are you referring to the beta CL or the original HEAD CL?
>
> I didn't specifically TBR the one for the beta branch; drover must have
> copied it from the original.
>
> The original was TBR because I felt it "had the appropriate level of
> review or general approval" from the metrics team and it deals only with
> metrics.  Granted, it doesn't touch hundreds of files.
>
> -- Brian
>
>
> On Tue, Jan 10, 2017 at 10:34 AM, <jochen@chromium.org> wrote:
>
> please don't TBR patches like this in the future
>
> patches that are Ok to be TBR'd are described here:
>
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
>
> https://codereview.chromium.org/2619203006/
>
>
>
>
> --
>   Brian
>   bcwhite@google.com
>
>
-----------------------------------------------------------------------------------------
>
>
>
> *Treat someone as they are and they will remain that way.Treat someone as
> they can be and they will become that way.*
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698