Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2604433002: Adjust memory sizes of persistent histogram allocations. (Closed)

Created:
3 years, 12 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust memory sizes of persistent histogram allocations. Most subprocesses have very few histograms and so use little of the memory they are given. 64KiB is a typical minimum allocation, though. Browser histogram memory usage has increased now that subprocess histograms are fully merged into the main process. BUG=675600 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2604433002 Cr-Commit-Position: refs/heads/master@{#441688} Committed: https://chromium.googlesource.com/chromium/src/+/867f4553745f6106db762b4260397740760aaacf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-03 19:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604433002/1
3 years, 11 months ago (2017-01-05 16:39:13 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:29:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/867f4553745f6106db762b426039...

Powered by Google App Engine
This is Rietveld 408576698