Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2619093002: Remove Context params from GeolocationHeader (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 11 months ago
Reviewers:
Yusuf, Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Context params from GeolocationHeader Methods of GeolocationHeader typically take a context, but the context is merely used to get the package name and start an Activity. We can instead use ContextUtils.getApplicationContext(). Review-Url: https://codereview.chromium.org/2619093002 Cr-Commit-Position: refs/heads/master@{#443019} Committed: https://chromium.googlesource.com/chromium/src/+/38d5cb2144655aad592209bb2a59d21be02df69d

Patch Set 1 #

Total comments: 2

Patch Set 2 : ebase #

Messages

Total messages: 17 (8 generated)
cco3
3 years, 11 months ago (2017-01-06 23:13:40 UTC) #2
Yusuf
lgtm
3 years, 11 months ago (2017-01-10 00:38:21 UTC) #3
cco3
Hi Maria, here's a similar application context change.
3 years, 11 months ago (2017-01-10 00:39:00 UTC) #5
Maria
lgtm https://codereview.chromium.org/2619093002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java (right): https://codereview.chromium.org/2619093002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java#newcode247 chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java:247: GeolocationTracker.getLastKnownLocation(ContextUtils.getApplicationContext()); doesn't fit on the line above?
3 years, 11 months ago (2017-01-10 01:11:34 UTC) #6
cco3
https://codereview.chromium.org/2619093002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java (right): https://codereview.chromium.org/2619093002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java#newcode247 chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java:247: GeolocationTracker.getLastKnownLocation(ContextUtils.getApplicationContext()); On 2017/01/10 01:11:34, Maria wrote: > doesn't fit ...
3 years, 11 months ago (2017-01-10 01:26:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619093002/1
3 years, 11 months ago (2017-01-10 01:27:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/18021) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-10 01:34:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619093002/20001
3 years, 11 months ago (2017-01-11 19:08:03 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:28:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38d5cb2144655aad592209bb2a59...

Powered by Google App Engine
This is Rietveld 408576698