chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java - Issue 2619093002: Remove Context params from GeolocationHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

Issue 2619093002: Remove Context params from GeolocationHeader (Closed)

Patch Set: ebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

index ea53fd1149a2bf706025b86e5429e98fbdcb5266..04b65fdf72b370a0f6df270479d4923a79c36810 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

@@ -106,7 +106,7 @@ public class GeolocationSnackbarController implements SnackbarController {

// Don't show the snackbar if Chrome doesn't have location permission since X-Geo won't be

// sent unless the user explicitly grants this permission.

- if (!GeolocationHeader.hasGeolocationPermission(context)) return true;

+ if (!GeolocationHeader.hasGeolocationPermission()) return true;

// Don't show the snackbar if Google isn't the default search engine since X-Geo won't be

// sent unless the user explicitly sets Google as their default search engine and sees that