src/gpu/gl/GrGLProgramEffects.h - Issue 26190003: Potentially optimize some GrGLEffects for known input color values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLProgramEffects.h

Issue 26190003: Potentially optimize some GrGLEffects for known input color values (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/gl/GrGLProgramEffects.h

diff --git a/src/gpu/gl/GrGLProgramEffects.h b/src/gpu/gl/GrGLProgramEffects.h

index 4572a4250d7c63e035db2f9266187d230ba25bf5..32007b8d099e57103409e7c0dbf50e90638336bb 100644

--- a/src/gpu/gl/GrGLProgramEffects.h

+++ b/src/gpu/gl/GrGLProgramEffects.h

@@ -135,7 +135,7 @@ public:

virtual void emitEffect(const GrEffectStage&,

GrGLProgramEffects::EffectKey,

const char* outColor,

- const char* inColor,

+ const GrGLSLExpr4& inColor,

int stageIndex) = 0;

};

@@ -167,7 +167,7 @@ private:

const GrEffectStage&,

GrGLProgramEffects::EffectKey,

const char* outColor,

- const char* inColor,

+ const GrGLSLExpr4& inColor,

int stageIndex);

/**

@@ -215,7 +215,7 @@ public:

virtual void emitEffect(const GrEffectStage&,

GrGLProgramEffects::EffectKey,

const char* outColor,

- const char* inColor,

+ const GrGLSLExpr4& inColor,

int stageIndex) SK_OVERRIDE;

/**

@@ -259,7 +259,7 @@ private:

const GrEffectStage&,

GrGLProgramEffects::EffectKey,

const char* outColor,

- const char* inColor,

+ const GrGLSLExpr4& inColor,

int stageIndex);

/**

@@ -302,7 +302,7 @@ public:

virtual void emitEffect(const GrEffectStage&,

GrGLProgramEffects::EffectKey,

const char* outColor,

- const char* inColor,

+ const GrGLSLExpr4& inColor,

int stageIndex) SK_OVERRIDE;

/**

« no previous file with comments | « src/gpu/gl/GrGLEffect.h ('k') | src/gpu/gl/GrGLProgramEffects.cpp » ('j') | no next file with comments »