Port Maps test to browser_test_runner harness.

Port Maps test to browser_test_runner harness.

This is the last Telemetry-based GPU test to use the old benchmark-based
harness. Delete all references to the now-obsolete telemetry_gpu_test
isolate, and as much of the old test harness as possible.

More cleanups are needed, in particular to remove the notion of Pages
from the test_expectations classes. These will be done in follow-on CLs.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618983004
Cr-Commit-Position: refs/heads/master@{#442155}
Committed: https://chromium.googlesource.com/chromium/src/+/566310e3c24f798a9bda03f01cf40edba4d1832a

[Ken Russell (switch to Gerrit), 2017-01-07 00:13:41]

Description was changed from

==========
Port Maps test to browser_test_runner harness.

This is the last Telemetry-based GPU test to use the old benchmark-based
harness. Delete all references to the now-obsolete telemetry_gpu_test
isolate, and as much of the old test harness as possible.

More cleanups are needed, in particular to remove the notion of Pages
from the test_expectations classes. These will be done in follow-on CLs.

BUG=352807
==========

to

==========
Port Maps test to browser_test_runner harness.

This is the last Telemetry-based GPU test to use the old benchmark-based
harness. Delete all references to the now-obsolete telemetry_gpu_test
isolate, and as much of the old test harness as possible.

More cleanups are needed, in particular to remove the notion of Pages
from the test_expectations classes. These will be done in follow-on CLs.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-01-07 00:23:16]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2017-01-07 00:23:16]

Mo: PTAL.

Others: FYI.

This is the last test that was referencing the old benchmark-based Telemetry GPU
harness! \o/ The remnants of it will be deleted in a follow-on CL.

[Ken Russell (switch to Gerrit), 2017-01-07 00:24:58]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 00:25:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-01-07 00:38:07]

On 2017/01/07 00:23:16, Ken Russell wrote:
> Mo: PTAL.
> 
> Others: FYI.
> 
> This is the last test that was referencing the old benchmark-based Telemetry
GPU
> harness! \o/ The remnants of it will be deleted in a follow-on CL.

lgtm

[commit-bot: I haz the power, 2017-01-07 01:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 01:28:00]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-01-07 04:27:58]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-01-07 04:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 04:32:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483763278948250, "parent_rev":
"e7565ba94652c87be04cd80f3722d52b418342df", "commit_rev":
"566310e3c24f798a9bda03f01cf40edba4d1832a"}

[commit-bot: I haz the power, 2017-01-07 04:32:36]

Description was changed from

==========
Port Maps test to browser_test_runner harness.

This is the last Telemetry-based GPU test to use the old benchmark-based
harness. Delete all references to the now-obsolete telemetry_gpu_test
isolate, and as much of the old test harness as possible.

More cleanups are needed, in particular to remove the notion of Pages
from the test_expectations classes. These will be done in follow-on CLs.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Port Maps test to browser_test_runner harness.

This is the last Telemetry-based GPU test to use the old benchmark-based
harness. Delete all references to the now-obsolete telemetry_gpu_test
isolate, and as much of the old test harness as possible.

More cleanups are needed, in particular to remove the notion of Pages
from the test_expectations classes. These will be done in follow-on CLs.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618983004
Cr-Commit-Position: refs/heads/master@{#442155}
Committed:
https://chromium.googlesource.com/chromium/src/+/566310e3c24f798a9bda03f01cf4...
==========

[commit-bot: I haz the power, 2017-01-07 04:32:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/566310e3c24f798a9bda03f01cf4...

[robertn, 2017-02-10 13:25:27]

Hi Ken!

On 2017/01/07 00:23:16, Ken Russell wrote:
> Mo: PTAL.
> 
> Others: FYI.
> 
> This is the last test that was referencing the old benchmark-based Telemetry
GPU
> harness! \o/ The remnants of it will be deleted in a follow-on CL.

I've noticed that run_gpu_test.py is still referenced from
generate_telemetry_harness.sh. Is it correct to assume that it should just be
removed, or should it be referencing something else?

[Ken Russell (switch to Gerrit), 2017-02-14 02:28:40]

On 2017/02/10 13:25:27, robertn wrote:
> Hi Ken!
> 
> On 2017/01/07 00:23:16, Ken Russell wrote:
> > Mo: PTAL.
> > 
> > Others: FYI.
> > 
> > This is the last test that was referencing the old benchmark-based Telemetry
> GPU
> > harness! \o/ The remnants of it will be deleted in a follow-on CL.
> 
> I've noticed that run_gpu_test.py is still referenced from
> generate_telemetry_harness.sh. Is it correct to assume that it should just be
> removed, or should it be referencing something else?

robertn: please file a bug about this in
https://github.com/catapult-project/catapult . I don't know where the
generate_telemetry_harness.sh script is run from at this point; it should
probably be deleted.