Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2616253002: Add typ boilerplate to Telemetry-based GPU tests. (Closed)

Created:
3 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
nednguyen, Dirk Pranke
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, eyaich1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add typ boilerplate to Telemetry-based GPU tests. BUG=636153 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/context_lost_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/depth_capture_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature_integration_test.py View 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/maps_integration_test.py View 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/path_util.py View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/trace_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/run_gpu_integration_test.py View 1 chunk +1 line, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
Ken Russell (switch to Gerrit)
Ned, Dirk: here's the boilerplate requested in https://codereview.chromium.org/2590623002/ (informed by https://codereview.chromium.org/2562913003 ) which will let ...
3 years, 11 months ago (2017-01-07 01:45:47 UTC) #3
Dirk Pranke
I looked a bit at this. after applying 2590623002 to tip-of-tree catapult and applying this ...
3 years, 11 months ago (2017-01-09 03:14:55 UTC) #4
nednguyen
On 2017/01/09 03:14:55, Dirk Pranke wrote: > I looked a bit at this. after applying ...
3 years, 11 months ago (2017-01-19 22:40:49 UTC) #5
nednguyen
lgtm
3 years, 11 months ago (2017-01-23 18:03:25 UTC) #6
Ken Russell (switch to Gerrit)
On 2017/01/23 18:03:25, nednguyen wrote: > lgtm Thanks Ned. If I understand this correctly, this ...
3 years, 11 months ago (2017-01-23 18:48:26 UTC) #7
nednguyen
On 2017/01/23 18:48:26, Ken Russell OOO-till-Jan-27 wrote: > On 2017/01/23 18:03:25, nednguyen wrote: > > ...
3 years, 11 months ago (2017-01-23 19:06:43 UTC) #8
Ken Russell (switch to Gerrit)
On 2017/01/23 19:06:43, nednguyen wrote: > On 2017/01/23 18:48:26, Ken Russell OOO-till-Jan-27 wrote: > > ...
3 years, 11 months ago (2017-01-23 19:34:52 UTC) #13
nednguyen
https://codereview.chromium.org/2616253002/diff/1/content/test/gpu/run_gpu_integration_test.py File content/test/gpu/run_gpu_integration_test.py (left): https://codereview.chromium.org/2616253002/diff/1/content/test/gpu/run_gpu_integration_test.py#oldcode28 content/test/gpu/run_gpu_integration_test.py:28: options = browser_test_runner.TestRunOptions() Oh, so this seems to be ...
3 years, 11 months ago (2017-01-23 20:30:35 UTC) #14
nednguyen
3 years, 10 months ago (2017-01-30 15:10:57 UTC) #15
On 2017/01/23 20:30:35, nednguyen wrote:
>
https://codereview.chromium.org/2616253002/diff/1/content/test/gpu/run_gpu_in...
> File content/test/gpu/run_gpu_integration_test.py (left):
> 
>
https://codereview.chromium.org/2616253002/diff/1/content/test/gpu/run_gpu_in...
> content/test/gpu/run_gpu_integration_test.py:28: options =
> browser_test_runner.TestRunOptions()
> Oh, so this seems to be the API breakage

Hmmh, another problem is that content/test/gpu/run_unittests.py picks up the
load_tests method in the module & fails because they are not designed for normal
unittests. I need to add some more logic to browser_test_runner so that they
bails out early if the load_tests is not run up by the browser_test_runner.

Powered by Google App Engine
This is Rietveld 408576698