Move seven small arrays to read-only data segment

Move seven small arrays to read-only data segment

Global arrays should be tagged as const when possible. This lets most
compilers put them in the read-only data segment which is always
shared between processes.

Two of the relevant structs also fell afoul of a VC++ bug that prevents
variables from being put in the read-only data segment. Thus this change
works by *adding* const eight times and *removing* it twice. The net
result is just 556 bytes being moved, but it's the thought that counts.

Compilers are awesome.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
Review-Url: https://codereview.chromium.org/2618873002
Cr-Commit-Position: refs/heads/master@{#442329}
Committed: https://chromium.googlesource.com/chromium/src/+/aef5c1f5d4a23b24300e2bc3e2099c14e48ce21e

[brucedawson, 2017-01-06 01:50:23]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:50:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-01-06 01:51:42]

Description was changed from

==========
Move seven small arrays to read-only data segment

Global arrays should be tagged as const when possible. This lets most
compilers put them in the read-only data segment which is always
shared between processes.

Two of the relevant structs also fell afoul of a VC++ bug that prevents
variables from being put in the read-only data segment. Thus this change
works by *adding* const eight times and *removing* it twice. The net
result is just 556 bytes being moved, but it's the thought that counts.

Compilers are awesome.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
==========

to

==========
Move seven small arrays to read-only data segment

Global arrays should be tagged as const when possible. This lets most
compilers put them in the read-only data segment which is always
shared between processes.

Two of the relevant structs also fell afoul of a VC++ bug that prevents
variables from being put in the read-only data segment. Thus this change
works by *adding* const eight times and *removing* it twice. The net
result is just 556 bytes being moved, but it's the thought that counts.

Compilers are awesome.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
==========

[brucedawson, 2017-01-06 01:51:42]

brucedawson@chromium.org changed reviewers:
+ jochen@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:52:39]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-09 08:38:23]

lgtm

[brucedawson, 2017-01-09 18:53:48]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:37:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483988028476250, "parent_rev":
"2eae822b42db92733336a5d6863107079ceb6e99", "commit_rev":
"aef5c1f5d4a23b24300e2bc3e2099c14e48ce21e"}

[commit-bot: I haz the power, 2017-01-09 20:37:54]

Description was changed from

==========
Move seven small arrays to read-only data segment

Global arrays should be tagged as const when possible. This lets most
compilers put them in the read-only data segment which is always
shared between processes.

Two of the relevant structs also fell afoul of a VC++ bug that prevents
variables from being put in the read-only data segment. Thus this change
works by *adding* const eight times and *removing* it twice. The net
result is just 556 bytes being moved, but it's the thought that counts.

Compilers are awesome.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351
==========

to

==========
Move seven small arrays to read-only data segment

Global arrays should be tagged as const when possible. This lets most
compilers put them in the read-only data segment which is always
shared between processes.

Two of the relevant structs also fell afoul of a VC++ bug that prevents
variables from being put in the read-only data segment. Thus this change
works by *adding* const eight times and *removing* it twice. The net
result is just 556 bytes being moved, but it's the thought that counts.

Compilers are awesome.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

BUG=677351

Review-Url: https://codereview.chromium.org/2618873002
Cr-Commit-Position: refs/heads/master@{#442329}
Committed:
https://chromium.googlesource.com/chromium/src/+/aef5c1f5d4a23b24300e2bc3e209...
==========

[commit-bot: I haz the power, 2017-01-09 20:37:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aef5c1f5d4a23b24300e2bc3e209...