Move seven small arrays to read-only data segment

chrome/browser/themes/browser_theme_pack.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/browser_theme_pack.h"
 
 #include <limits.h>
 #include <stddef.h>
 
 #include <limits>
@@ skipping 78 matching lines @@
   // A non-changing integer ID meant to be saved in theme packs. This ID must
   // not change between versions of chrome.
   int persistent_id;
 
   // The IDR that depends on the whims of GRIT and therefore changes whenever
   // someone adds a new resource.
   int idr_id;
 
   // String to check for when parsing theme manifests or NULL if this isn't
   // supposed to be changeable by the user.
-  const char* const key;
+  const char* key;
 };
 
 // IDR_* resource names change whenever new resources are added; use persistent
 // IDs when storing to a cached pack.
-PersistingImagesTable kPersistingImages[] = {
+const PersistingImagesTable kPersistingImages[] = {
     {PRS_THEME_FRAME, IDR_THEME_FRAME, "theme_frame"},
     {PRS_THEME_FRAME_INACTIVE, IDR_THEME_FRAME_INACTIVE,
      "theme_frame_inactive"},
     {PRS_THEME_FRAME_INCOGNITO, IDR_THEME_FRAME_INCOGNITO,
      "theme_frame_incognito"},
     {PRS_THEME_FRAME_INCOGNITO_INACTIVE, IDR_THEME_FRAME_INCOGNITO_INACTIVE,
      "theme_frame_incognito_inactive"},
     {PRS_THEME_TOOLBAR, IDR_THEME_TOOLBAR, "theme_toolbar"},
     {PRS_THEME_TAB_BACKGROUND, IDR_THEME_TAB_BACKGROUND,
      "theme_tab_background"},
@@ skipping 83 matching lines @@
   std::unique_ptr<float[]> scales(new float[scale_factors.size()]);
   for (size_t i = 0; i < scale_factors.size(); ++i)
     scales[i] = ui::GetScaleForScaleFactor(scale_factors[i]);
   std::string out_string = std::string(
       reinterpret_cast<const char*>(scales.get()),
       scale_factors.size() * sizeof(float));
   return out_string;
 }
 
 struct StringToIntTable {
-  const char* const key;
+  const char* key;
   ThemeProperties::OverwritableByUserThemeProperty id;
 };
 
 // Strings used by themes to identify tints in the JSON.
-StringToIntTable kTintTable[] = {
+const StringToIntTable kTintTable[] = {
   { "buttons", ThemeProperties::TINT_BUTTONS },
   { "frame", ThemeProperties::TINT_FRAME },
   { "frame_inactive", ThemeProperties::TINT_FRAME_INACTIVE },
   { "frame_incognito", ThemeProperties::TINT_FRAME_INCOGNITO },
   { "frame_incognito_inactive",
     ThemeProperties::TINT_FRAME_INCOGNITO_INACTIVE },
   { "background_tab", ThemeProperties::TINT_BACKGROUND_TAB },
 };
 const size_t kTintTableLength = arraysize(kTintTable);
 
 // Strings used by themes to identify colors in the JSON.
-StringToIntTable kColorTable[] = {
+const StringToIntTable kColorTable[] = {
   { "frame", ThemeProperties::COLOR_FRAME },
   { "frame_inactive", ThemeProperties::COLOR_FRAME_INACTIVE },
   { "frame_incognito", ThemeProperties::COLOR_FRAME_INCOGNITO },
   { "frame_incognito_inactive",
     ThemeProperties::COLOR_FRAME_INCOGNITO_INACTIVE },
   { "toolbar", ThemeProperties::COLOR_TOOLBAR },
   { "tab_text", ThemeProperties::COLOR_TAB_TEXT },
   { "tab_background_text", ThemeProperties::COLOR_BACKGROUND_TAB_TEXT },
   { "bookmark_text", ThemeProperties::COLOR_BOOKMARK_TEXT },
   { "ntp_background", ThemeProperties::COLOR_NTP_BACKGROUND },
   { "ntp_text", ThemeProperties::COLOR_NTP_TEXT },
   { "ntp_link", ThemeProperties::COLOR_NTP_LINK },
   { "ntp_link_underline", ThemeProperties::COLOR_NTP_LINK_UNDERLINE },
   { "ntp_header", ThemeProperties::COLOR_NTP_HEADER },
   { "ntp_section", ThemeProperties::COLOR_NTP_SECTION },
   { "ntp_section_text", ThemeProperties::COLOR_NTP_SECTION_TEXT },
   { "ntp_section_link", ThemeProperties::COLOR_NTP_SECTION_LINK },
   { "ntp_section_link_underline",
     ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE },
   { "button_background", ThemeProperties::COLOR_BUTTON_BACKGROUND },
 };
 const size_t kColorTableLength = arraysize(kColorTable);
 
 // Strings used by themes to identify display properties keys in JSON.
-StringToIntTable kDisplayProperties[] = {
+const StringToIntTable kDisplayProperties[] = {
   { "ntp_background_alignment",
     ThemeProperties::NTP_BACKGROUND_ALIGNMENT },
   { "ntp_background_repeat", ThemeProperties::NTP_BACKGROUND_TILING },
   { "ntp_logo_alternate", ThemeProperties::NTP_LOGO_ALTERNATE },
 };
 const size_t kDisplayPropertiesSize = arraysize(kDisplayProperties);
 
 int GetIntForString(const std::string& key,
-                    StringToIntTable* table,
+                    const StringToIntTable* table,
                     size_t table_length) {
   for (size_t i = 0; i < table_length; ++i) {
     if (base::LowerCaseEqualsASCII(key, table[i].key)) {
       return table[i].id;
     }
   }
 
   return -1;
 }
 
 struct IntToIntTable {
   int key;
   int value;
 };
 
 // Mapping used in CreateFrameImages() to associate frame images with the
 // tint ID that should maybe be applied to it.
-IntToIntTable kFrameTintMap[] = {
+const IntToIntTable kFrameTintMap[] = {
   { PRS_THEME_FRAME, ThemeProperties::TINT_FRAME },
   { PRS_THEME_FRAME_INACTIVE, ThemeProperties::TINT_FRAME_INACTIVE },
   { PRS_THEME_FRAME_OVERLAY, ThemeProperties::TINT_FRAME },
   { PRS_THEME_FRAME_OVERLAY_INACTIVE,
     ThemeProperties::TINT_FRAME_INACTIVE },
   { PRS_THEME_FRAME_INCOGNITO, ThemeProperties::TINT_FRAME_INCOGNITO },
   { PRS_THEME_FRAME_INCOGNITO_INACTIVE,
     ThemeProperties::TINT_FRAME_INCOGNITO_INACTIVE },
 };
 
 // Mapping used in GenerateTabBackgroundImages() to associate what frame image
 // goes with which tab background.
-IntToIntTable kTabBackgroundMap[] = {
+const IntToIntTable kTabBackgroundMap[] = {
   { PRS_THEME_TAB_BACKGROUND, PRS_THEME_FRAME },
   { PRS_THEME_TAB_BACKGROUND_INCOGNITO, PRS_THEME_FRAME_INCOGNITO },
 };
 
 struct CropEntry {
   int prs_id;
 
   // The maximum useful height of the image at |prs_id|.
   int max_height;
 
   // Whether cropping the image at |prs_id| should be skipped on OSes which
   // have a frame border to the left and right of the web contents.
   // This should be true for images which can be used to decorate the border to
   // the left and the right of the web contents.
   bool skip_if_frame_border;
 };
 
 // The images which should be cropped before being saved to the data pack. The
 // maximum heights are meant to be conservative as to give room for the UI to
 // change without the maximum heights having to be modified.
 // |kThemePackVersion| must be incremented if any of the maximum heights below
 // are modified.
-struct CropEntry kImagesToCrop[] = {
+const struct CropEntry kImagesToCrop[] = {
   { PRS_THEME_FRAME, 120, true },
   { PRS_THEME_FRAME_INACTIVE, 120, true },
   { PRS_THEME_FRAME_INCOGNITO, 120, true },
   { PRS_THEME_FRAME_INCOGNITO_INACTIVE, 120, true },
   { PRS_THEME_FRAME_OVERLAY, 120, true },
   { PRS_THEME_FRAME_OVERLAY_INACTIVE, 120, true },
   { PRS_THEME_TOOLBAR, 200, false },
   { PRS_THEME_BUTTON_BACKGROUND, 60, false },
   { PRS_THEME_WINDOW_CONTROL_BACKGROUND, 50, false },
 };
@@ skipping 1128 matching lines @@
                                            false,
                                            &bitmap_data)) {
       NOTREACHED() << "Unable to encode theme image for prs_id="
                    << prs_id << " for scale_factor=" << scale_factors_[i];
       break;
     }
     image_memory_[scaled_raw_id] =
         base::RefCountedBytes::TakeVector(&bitmap_data);
   }
 }