Add SignalStrength to Cellular {Managed}Properties

Add SignalStrength to Cellular {Managed}Properties

SignalStrength was a member of CellularStateProperties, but not
Cellular{Managed}Properties which are supposed to be a superset.

BUG=none

Review-Url: https://codereview.chromium.org/2618793004
Cr-Commit-Position: refs/heads/master@{#441843}
Committed: https://chromium.googlesource.com/chromium/src/+/1c3d20c3c1df3b9fa6fa07092b009abe3c6510df

[stevenjb, 2017-01-05 21:55:39]

stevenjb@chromium.org changed reviewers:
+ asargent@chromium.org, rdevlin.cronin@chromium.org

[stevenjb, 2017-01-05 22:26:50]

stevenjb@chromium.org changed reviewers:
+ reillyg@chromium.org
- asargent@chromium.org

[stevenjb, 2017-01-05 22:26:50]

s/asargent/reillyg

[Reilly Grant (use Gerrit), 2017-01-05 22:31:00]

lgtm with nits

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
File third_party/closure_compiler/externs/networking_private.js (right):

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/networking_private.js:1: // Copyright 2017
The Chromium Authors. All rights reserved.
We don't update copyright dates.

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/networking_private.js:1284: *     state of.
    If empty, the default cellular device will be used.
nit: Only one space between sentences.

[stevenjb, 2017-01-05 22:45:29]

Thanks for the quick review.

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
File third_party/closure_compiler/externs/networking_private.js (right):

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/networking_private.js:1: // Copyright 2017
The Chromium Authors. All rights reserved.
On 2017/01/05 22:30:59, Reilly Grant wrote:
> We don't update copyright dates.

This is generated, so the alternative is to hand edit this any time the idl is
updated, which I would prefer to avoid.

https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/networking_private.js:1284: *     state of.
    If empty, the default cellular device will be used.
On 2017/01/05 22:30:59, Reilly Grant wrote:
> nit: Only one space between sentences.

Also generated, we have this problem throughout these externs.

[stevenjb, 2017-01-05 22:45:35]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:46:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-01-05 22:46:58]

On 2017/01/05 22:45:29, stevenjb wrote:
> Thanks for the quick review.
> 
>
https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
> File third_party/closure_compiler/externs/networking_private.js (right):
> 
>
https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
> third_party/closure_compiler/externs/networking_private.js:1: // Copyright
2017
> The Chromium Authors. All rights reserved.
> On 2017/01/05 22:30:59, Reilly Grant wrote:
> > We don't update copyright dates.
> 
> This is generated, so the alternative is to hand edit this any time the idl is
> updated, which I would prefer to avoid.
> 
>
https://codereview.chromium.org/2618793004/diff/1/third_party/closure_compile...
> third_party/closure_compiler/externs/networking_private.js:1284: *     state
of.
>     If empty, the default cellular device will be used.
> On 2017/01/05 22:30:59, Reilly Grant wrote:
> > nit: Only one space between sentences.
> 
> Also generated, we have this problem throughout these externs.

*grumbles about checking in generated code*

[Devlin, 2017-01-05 23:32:37]

lgtm

Note that I'm not at all familiar with onc, so up to you if you want a reviewer
for that file.

On 2017/01/05 22:46:58, Reilly Grant wrote:
> *grumbles about checking in generated code*

It's better than it was, where these were handwritten.  And hopefully it'll be
better yet with https://codereview.chromium.org/2583573002/, but we'll see how
that goes.

[stevenjb, 2017-01-05 23:47:21]

On 2017/01/05 23:32:37, Devlin (sheriff - maybe slow) wrote:
> lgtm
> 
> Note that I'm not at all familiar with onc, so up to you if you want a
reviewer
> for that file.
> 
If only we still had someone else on the team maintaining it.... sigh.

> On 2017/01/05 22:46:58, Reilly Grant wrote:
> > *grumbles about checking in generated code*
> 
> It's better than it was, where these were handwritten.  And hopefully it'll be
> better yet with https://codereview.chromium.org/2583573002/, but we'll see how
> that goes.

Hooray!

[commit-bot: I haz the power, 2017-01-06 02:42:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483656335214340, "parent_rev":
"a75163e6ee0d3dcd5b929bbadcb5cd23bd15d636", "commit_rev":
"1c3d20c3c1df3b9fa6fa07092b009abe3c6510df"}

[commit-bot: I haz the power, 2017-01-06 02:42:54]

Description was changed from

==========
Add SignalStrength to Cellular {Managed}Properties

SignalStrength was a member of CellularStateProperties, but not
Cellular{Managed}Properties which are supposed to be a superset.

BUG=none
==========

to

==========
Add SignalStrength to Cellular {Managed}Properties

SignalStrength was a member of CellularStateProperties, but not
Cellular{Managed}Properties which are supposed to be a superset.

BUG=none

Review-Url: https://codereview.chromium.org/2618793004
Cr-Commit-Position: refs/heads/master@{#441843}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c3d20c3c1df3b9fa6fa07092b00...
==========

[commit-bot: I haz the power, 2017-01-06 02:42:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c3d20c3c1df3b9fa6fa07092b00...