Add SignalStrength to Cellular {Managed}Properties

third_party/closure_compiler/externs/networking_private.js

Index: third_party/closure_compiler/externs/networking_private.js
diff --git a/third_party/closure_compiler/externs/networking_private.js b/third_party/closure_compiler/externs/networking_private.js
index 8a1a78f8e6183c7257c5d37210d93f2d896fd3a3..5c7c329a3078d0805f12101b761d50a793d6d40f 100644
--- a/third_party/closure_compiler/externs/networking_private.js
+++ b/third_party/closure_compiler/externs/networking_private.js
@@ -1,4 +1,4 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors. All rights reserved.

[Reilly Grant (use Gerrit), 2017/01/05 22:30:59]

We don't update copyright dates.

[stevenjb, 2017/01/05 22:45:29]

This is generated, so the alternative is to hand edit this any time the idl is
updated, which I would prefer to avoid.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -412,7 +412,7 @@ chrome.networkingPrivate.IPSecProperties;
  *   ClientCertType: (!chrome.networkingPrivate.ManagedDOMString|undefined),
  *   EAP: (!chrome.networkingPrivate.ManagedEAPProperties|undefined),
  *   Group: (!chrome.networkingPrivate.ManagedDOMString|undefined),
- *   IKEVersion: !chrome.networkingPrivate.ManagedLong,
+ *   IKEVersion: (!chrome.networkingPrivate.ManagedLong|undefined),
  *   PSK: (!chrome.networkingPrivate.ManagedDOMString|undefined),
  *   SaveCredentials: (!chrome.networkingPrivate.ManagedBoolean|undefined),
  *   ServerCARefs: (!chrome.networkingPrivate.ManagedDOMStringList|undefined),
@@ -674,6 +674,7 @@ chrome.networkingPrivate.ManagedThirdPartyVPNProperties;
  *   ServingOperator: (!chrome.networkingPrivate.CellularProviderProperties|undefined),
  *   SIMLockStatus: (!chrome.networkingPrivate.SIMLockStatus|undefined),
  *   SIMPresent: (boolean|undefined),
+ *   SignalStrength: (number|undefined),
  *   SupportNetworkScan: (boolean|undefined),
  *   SupportedCarriers: (!Array<string>|undefined)
  * }}
@@ -711,6 +712,7 @@ chrome.networkingPrivate.CellularProperties;
  *   ServingOperator: (!chrome.networkingPrivate.CellularProviderProperties|undefined),
  *   SIMLockStatus: (!chrome.networkingPrivate.SIMLockStatus|undefined),
  *   SIMPresent: (boolean|undefined),
+ *   SignalStrength: (number|undefined),
  *   SupportNetworkScan: (boolean|undefined),
  *   SupportedCarriers: (!Array<string>|undefined)
  * }}
@@ -1262,6 +1264,7 @@ chrome.networkingPrivate.getCaptivePortalStatus = function(networkGuid, callback
  * succeeds (|puk| is valid), the PIN will be set to |pin|.   (If |pin| is empty
  * or invalid the operation will fail).
  * @param {string} networkGuid The GUID of the cellular network to unlock.
+ *     If empty, the default cellular device will be used.
  * @param {string} pin The current SIM PIN, or the new PIN if PUK is provided.
  * @param {string=} puk The operator provided PUK for unblocking a blocked SIM.
  * @param {function():void=} callback Called when the operation has completed.
@@ -1278,7 +1281,7 @@ chrome.networkingPrivate.unlockCellularSim = function(networkGuid, pin, puk, cal
  * unlockCellularSim() before this can be called (otherwise it will fail and
  * chrome.runtime.lastError will be set to Error.SimLocked).
  * @param {string} networkGuid The GUID of the cellular network to set the SIM
- *     state of.
+ *     state of.     If empty, the default cellular device will be used.

[Reilly Grant (use Gerrit), 2017/01/05 22:30:59]

nit: Only one space between sentences.

[stevenjb, 2017/01/05 22:45:29]

Also generated, we have this problem throughout these externs.

  * @param {!chrome.networkingPrivate.CellularSimState} simState The SIM state to
  *     set.
  * @param {function():void=} callback Called when the operation has completed.