Group content suggestions notifications separately

Group content suggestions notifications separately

Without this, the notification could get grouped with one of the other
types of Chrome notifications.

BUG=675961
Review-Url: https://codereview.chromium.org/2618733003
Cr-Commit-Position: refs/heads/master@{#441955}
Committed: https://chromium.googlesource.com/chromium/src/+/6f439cbe3aed0f47ed16c82a5f28e51c87a69a72

[sfiera, 2017-01-05 14:19:42]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 14:19:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-01-05 14:21:11]

sfiera@chromium.org changed reviewers:
+ dgn@chromium.org

[sfiera, 2017-01-05 14:21:11]

I try not to send Bernhard everything :)

[dgn, 2017-01-06 12:25:30]

Did you try it on different android versions? 

KK, L and N have different ways of handling notifications. 

Do we expect it to be possible to have more than one of these notifications? If
that's the case, you will also need a group summary
https://medium.com/exploring-android/android-n-introducing-upgraded-notificat...

You can just set groupSummary to true anyway (see
https://codereview.chromium.org/2576393002) but I don't know why.

+dfalcantara@, hoping for a good explanation why he recommended that.

[sfiera, 2017-01-06 12:34:49]

This was in response to
https://groups.google.com/a/google.com/forum/#!topic/zine-eng/3ggz96rFd-w

Right now only one content suggestion notification will be shown at a time, so
it's not important if or how it groups with itself, but it is important that it
not group with notifications for incognito, downloads, &c.

I don't actually have an N device to test with at the moment.

[dgn, 2017-01-06 13:27:04]

On 2017/01/06 12:34:49, sfiera wrote:
> This was in response to
> https://groups.google.com/a/google.com/forum/#!topic/zine-eng/3ggz96rFd-w
> 
> Right now only one content suggestion notification will be shown at a time, so
> it's not important if or how it groups with itself, but it is important that
it
> not group with notifications for incognito, downloads, &c.
> 
> I don't actually have an N device to test with at the moment.

If we have only one it's probably fine as it is. lgtm

[sfiera, 2017-01-06 15:37:51]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 15:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:16:05]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-01-06 17:04:38]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:10:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483722278285760,
"parent_rev": "c302a98ceb085bf25d0c004e666d64fd4c3ee9f6", "commit_rev":
"6f439cbe3aed0f47ed16c82a5f28e51c87a69a72"}

[commit-bot: I haz the power, 2017-01-06 17:10:41]

Description was changed from

==========
Group content suggestions notifications separately

Without this, the notification could get grouped with one of the other
types of Chrome notifications.

BUG=675961
==========

to

==========
Group content suggestions notifications separately

Without this, the notification could get grouped with one of the other
types of Chrome notifications.

BUG=675961

Review-Url: https://codereview.chromium.org/2618733003
Cr-Commit-Position: refs/heads/master@{#441955}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f439cbe3aed0f47ed16c82a5f28...
==========

[commit-bot: I haz the power, 2017-01-06 17:10:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f439cbe3aed0f47ed16c82a5f28...