Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576393002:
Media Notifications: call setGroup() to prevent Android N auto-groupping. (Closed)
|
Created:
4 years ago by mlamouri (slow - plz ping) Modified:
4 years ago CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMedia Notifications: call setGroup() to prevent Android N auto-groupping.
There are three types of media notifications and they each have a
different group. At the moment, only one of each can be shown.
BUG=674676
R=dfalcantara@chromium.org, zqzhang@chromium.org
Committed: https://crrev.com/e91cbbdc86009dc07e92770129d6e3fd246bb2c9
Cr-Commit-Position: refs/heads/master@{#438919}
Patch Set 1 #
Total comments: 2
Patch Set 2 : review comment #Messages
Total messages: 17 (10 generated)
The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm https://codereview.chromium.org/2576393002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2576393002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:733: mNotificationBuilder.setGroup(getNotificationGroupName()); Might want to call setGroupSummary, too.
Description was changed from ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674015 R=dfalcantara@chromium.org, zqzhang@chromium.org ========== to ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674676 R=dfalcantara@chromium.org, zqzhang@chromium.org ==========
https://codereview.chromium.org/2576393002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2576393002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:733: mNotificationBuilder.setGroup(getNotificationGroupName()); On 2016/12/15 at 18:55:59, dfalcantara (check my queue) wrote: > Might want to call setGroupSummary, too. Done.
The CQ bit was checked by mlamouri@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org, zqzhang@chromium.org Link to the patchset: https://codereview.chromium.org/2576393002/#ps20001 (title: "review comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481832861148540,
"parent_rev": "f7003493891823e9c0d264fa4084fa6c100f22a4", "commit_rev":
"2beb1bb493f1510f9af17f737f3a6eee51bd976e"}
Message was sent while issue was closed.
Description was changed from ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674676 R=dfalcantara@chromium.org, zqzhang@chromium.org ========== to ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674676 R=dfalcantara@chromium.org, zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2576393002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674676 R=dfalcantara@chromium.org, zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2576393002 ========== to ========== Media Notifications: call setGroup() to prevent Android N auto-groupping. There are three types of media notifications and they each have a different group. At the moment, only one of each can be shown. BUG=674676 R=dfalcantara@chromium.org, zqzhang@chromium.org Committed: https://crrev.com/e91cbbdc86009dc07e92770129d6e3fd246bb2c9 Cr-Commit-Position: refs/heads/master@{#438919} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e91cbbdc86009dc07e92770129d6e3fd246bb2c9 Cr-Commit-Position: refs/heads/master@{#438919} |
