|
|
DescriptionImplements CSSPropertyAPI for the webkit-highlight property.
A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitHighlight from the switch statement in
parseSingleValue, and calls the API instead.
A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.
This patch:
- Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
CSSPropertyAPWebkitHighlight.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h.
BUG=668012
Review-Url: https://codereview.chromium.org/2618673002
Cr-Commit-Position: refs/heads/master@{#443974}
Committed: https://chromium.googlesource.com/chromium/src/+/28b3296d10b12eedd7cb0d12f1f2b5f5d93ba3c7
Patch Set 1 #Patch Set 2 : fixed dependencies, changed year #Patch Set 3 : dependencies #
Total comments: 1
Patch Set 4 : rebase #Patch Set 5 : rebase #Patch Set 6 : rebase #Patch Set 7 : rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 41 (35 generated)
aazzam@google.com changed reviewers: + meade@chromium.org
lgtm
Description was changed from ========== Implemented CSSPropertyAPI for webkit-highlight property. Added CSSPropertyAPIWebkitHighlight which implements CSSPropertyAPI for the webkit-highlight property. Moved parsing logic from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ========== to ========== Implemented CSSPropertyAPI for webkit-highlight property. Added CSSPropertyAPIWebkitHighlight which implements CSSPropertyAPI for the webkit-highlight property. Parsing logic is the same as before, just was moved from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ==========
aazzam@google.com changed reviewers: + sashab@chromium.org
sashab rs lgtm please :)
lgtm https://codereview.chromium.org/2618673002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp (right): https://codereview.chromium.org/2618673002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitHighlight.cpp:7: #include "core/css/CSSStringValue.h" This isn't needed
Description was changed from ========== Implemented CSSPropertyAPI for webkit-highlight property. Added CSSPropertyAPIWebkitHighlight which implements CSSPropertyAPI for the webkit-highlight property. Parsing logic is the same as before, just was moved from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ========== to ========== Implemented CSSPropertyAPI for the webkit-highlight property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitHighlight from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPWebkitHighlight.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h. BUG=668012 ==========
Description was changed from ========== Implemented CSSPropertyAPI for the webkit-highlight property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitHighlight from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPWebkitHighlight.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h. BUG=668012 ========== to ========== Implements CSSPropertyAPI for the webkit-highlight property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitHighlight from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPWebkitHighlight.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h. BUG=668012 ==========
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aazzam@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org, sashab@chromium.org Link to the patchset: https://codereview.chromium.org/2618673002/#ps120001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484621320326280, "parent_rev": "4d9ac69e1d31844585fa7500d4839553e327312b", "commit_rev": "28b3296d10b12eedd7cb0d12f1f2b5f5d93ba3c7"}
Message was sent while issue was closed.
Description was changed from ========== Implements CSSPropertyAPI for the webkit-highlight property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitHighlight from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPWebkitHighlight.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h. BUG=668012 ========== to ========== Implements CSSPropertyAPI for the webkit-highlight property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitHighlight from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIWebkitHighlight.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPWebkitHighlight.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIWebkitHighlight.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2618673002 Cr-Commit-Position: refs/heads/master@{#443974} Committed: https://chromium.googlesource.com/chromium/src/+/28b3296d10b12eedd7cb0d12f1f2... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/28b3296d10b12eedd7cb0d12f1f2... |