Implements CSSPropertyAPI for the webkit-line-clamp property.

Implements CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2615813002
Cr-Commit-Position: refs/heads/master@{#443976}
Committed: https://chromium.googlesource.com/chromium/src/+/10c6effbdc2a0fe344bb4451a16a6a12c046dc6a

[aazzam, 2017-01-05 04:11:36]

aazzam@google.com changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-05 04:15:06]

lgtm

https://codereview.chromium.org/2615813002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
(right):

https://codereview.chromium.org/2615813002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp:10:
#include "core/css/parser/CSSPropertyParserHelpers.h"
We normally have a new line before the namespace start.

[aazzam, 2017-01-05 04:34:50]

Description was changed from

==========
Implemented CSSPropertyAPI for webkit-line-clamp property.

Added CSSPropertyAPIWebkitLineClamp which implements CSSPropertyAPI for
the webkit-line-clamp property. Moved parsing logic from
CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so
that the .h file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for webkit-line-clamp property.

Added CSSPropertyAPIWebkitLineClamp which implements CSSPropertyAPI for
the webkit-line-clamp property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-06 03:15:19]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-06 03:15:20]

sashab rs lgtm please :)

[sashab, 2017-01-06 05:28:43]

lgtm

https://codereview.chromium.org/2615813002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp
(right):

https://codereview.chromium.org/2615813002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLineClamp.cpp:7:
#include "core/css/parser/CSSPropertyParserHelpers.h"
+ CSSPrimitiveValue

[aazzam, 2017-01-08 01:46:06]

Description was changed from

==========
Implemented CSSPropertyAPI for webkit-line-clamp property.

Added CSSPropertyAPIWebkitLineClamp which implements CSSPropertyAPI for
the webkit-line-clamp property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 01:58:05]

Description was changed from

==========
Implemented CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-10 00:23:50]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:25:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:35:39]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 02:31:53]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:01:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aazzam, 2017-01-11 06:29:47]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:30:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-01-11 07:00:49]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:05:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[aazzam, 2017-01-16 23:13:26]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 23:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:26:04]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[aazzam, 2017-01-16 23:46:04]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:46:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 01:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 01:34:10]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-17 02:54:04]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-17 02:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2615813002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-17 02:54:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 02:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484621644267360,
"parent_rev": "987e893acb7c289d99efbdcabdeec5c8481685b1", "commit_rev":
"10c6effbdc2a0fe344bb4451a16a6a12c046dc6a"}

[commit-bot: I haz the power, 2017-01-17 02:58:33]

Description was changed from

==========
Implements CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the webkit-line-clamp property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitLineClamp from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitLineClamp.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitLineClamp.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitLineClamp.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2615813002
Cr-Commit-Position: refs/heads/master@{#443976}
Committed:
https://chromium.googlesource.com/chromium/src/+/10c6effbdc2a0fe344bb4451a16a...
==========

[commit-bot: I haz the power, 2017-01-17 02:58:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/10c6effbdc2a0fe344bb4451a16a...