Implements CSSPropertyAPI for the caret-color property.

Implements CSSPropertyAPI for the caret-color property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2618613002
Cr-Commit-Position: refs/heads/master@{#442807}
Committed: https://chromium.googlesource.com/chromium/src/+/5238291dc55a45a16dce3f623b54ad24f47f0798

[aazzam, 2017-01-05 04:01:22]

aazzam@google.com changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2017-01-05 04:11:28]

lgtm

[aazzam, 2017-01-05 04:27:10]

Description was changed from

==========
Implemented CSSPropertyAPI for caret-color property.

Added CSSPropertyAPICaretColor which implements CSSPropertyAPI for
the caret-color property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for caret-color property.

Added CSSPropertyAPICaretColor which implements CSSPropertyAPI for
the caret-color property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-08 02:52:58]

Description was changed from

==========
Implemented CSSPropertyAPI for caret-color property.

Added CSSPropertyAPICaretColor which implements CSSPropertyAPI for
the caret-color property. Parsing logic is the same as before, 
just was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the caret-color property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 02:53:03]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-09 03:40:51]

Anna -- another thing you can do before sending this out is run 'git cl try',
which will run all the trybots and help find small errors :)

https://codereview.chromium.org/2618613002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp
(right):

https://codereview.chromium.org/2618613002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPICaretColor.cpp:15:
if (range.peek().id() == CSSValueAuto) {
Not quite right -- two if-statements here, should just be one :)

[aazzam, 2017-01-10 00:12:17]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:18:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-10 06:08:05]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 08:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:23:07]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 01:50:28]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:50:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-11 02:37:52]

lgtm

[commit-bot: I haz the power, 2017-01-11 04:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:10:40]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 05:06:19]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 05:06:19]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2618613002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 05:06:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 05:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484111179233390,
"parent_rev": "f8619fbad727b0046a671343f94bd711d9f1ddb8", "commit_rev":
"5238291dc55a45a16dce3f623b54ad24f47f0798"}

[commit-bot: I haz the power, 2017-01-11 05:12:19]

Description was changed from

==========
Implements CSSPropertyAPI for the caret-color property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the caret-color property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2618613002
Cr-Commit-Position: refs/heads/master@{#442807}
Committed:
https://chromium.googlesource.com/chromium/src/+/5238291dc55a45a16dce3f623b54...
==========

[commit-bot: I haz the power, 2017-01-11 05:12:20]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5238291dc55a45a16dce3f623b54...