Implements CSSPropertyAPI for the clip property.

Implements CSSPropertyAPI for the clip property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2614783003
Cr-Commit-Position: refs/heads/master@{#442810}
Committed: https://chromium.googlesource.com/chromium/src/+/3f6fb5a1899d4ad52e4997f0f309c221497fe561

[aazzam, 2017-01-05 04:00:31]

aazzam@google.com changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2017-01-05 04:10:22]

lgtm

https://codereview.chromium.org/2614783003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
(right):

https://codereview.chromium.org/2614783003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp:15: static
CSSValue* consumeClipComponent(CSSParserTokenRange& range,
You could make this helper method more private by putting it into an anonymous
namespace (instead of making it static).

[aazzam, 2017-01-05 04:26:58]

Description was changed from

==========
Implemented CSSPropertyAPI for clip property.

Added CSSPropertyAPIClip which implements CSSPropertyAPI for
the clip property. Moved parsing logic from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h file
will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for clip property.

Added CSSPropertyAPIClip which implements CSSPropertyAPI for
the clip property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-08 02:52:00]

Description was changed from

==========
Implemented CSSPropertyAPI for clip property.

Added CSSPropertyAPIClip which implements CSSPropertyAPI for
the clip property. Parsing logic is the same as before, just
was moved from CSSPropertyParser to the .cpp file. Added flag 
to CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the clip property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 02:52:08]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-09 03:42:21]

https://codereview.chromium.org/2614783003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp
(right):

https://codereview.chromium.org/2614783003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClip.cpp:13: static
CSSValue* consumeClipComponent(CSSParserTokenRange& range,
What Eddy said - anonymous namespace ;)

ie

namespace {

CSSValue* consume...

}

[aazzam, 2017-01-10 00:12:27]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:18:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:18:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-10 06:08:00]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:08:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 08:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:14:47]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 01:51:38]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:49:35]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-11 05:13:05]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-11 05:13:05]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2614783003/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-11 05:13:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-11 05:20:17]

lgtm

[commit-bot: I haz the power, 2017-01-11 05:20:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 05:20:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aazzam, 2017-01-11 05:21:00]

The CQ bit was checked by aazzam@google.com

[commit-bot: I haz the power, 2017-01-11 05:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 05:24:53]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484112060447290,
"parent_rev": "f6772d3dcc76f65a4b72cd81bd1ab25d3f295c6b", "commit_rev":
"3f6fb5a1899d4ad52e4997f0f309c221497fe561"}

[commit-bot: I haz the power, 2017-01-11 05:25:23]

Description was changed from

==========
Implements CSSPropertyAPI for the clip property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the clip property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614783003
Cr-Commit-Position: refs/heads/master@{#442810}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f6fb5a1899d4ad52e4997f0f309...
==========

[commit-bot: I haz the power, 2017-01-11 05:25:24]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/3f6fb5a1899d4ad52e4997f0f309...