Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2618553003: CSS Properties & Values API: Support <resolution> values (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
Reviewers:
meade_UTC10, rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Properties & Values API: Support <resolution> values This patch adds support for <resolution>-typed registered properties. We already parse the string '<resolution>', so this patch just adds the logic to parse the actual <resolution> values. BUG=641877 Review-Url: https://codereview.chromium.org/2618553003 Cr-Commit-Position: refs/heads/master@{#441795} Committed: https://chromium.googlesource.com/chromium/src/+/116448501b2ceb72233df9dde44ed4b874ff1e25

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
Timothy Loh
3 years, 11 months ago (2017-01-05 07:06:55 UTC) #2
rune
lgtm
3 years, 11 months ago (2017-01-05 12:29:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618553003/1
3 years, 11 months ago (2017-01-06 01:25:40 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:36:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/116448501b2ceb72233df9dde44e...

Powered by Google App Engine
This is Rietveld 408576698