third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp - Issue 2618553003: CSS Properties & Values API: Support <resolution> values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

Issue 2618553003: CSS Properties & Values API: Support <resolution> values (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

index 813c6579b00b6d1111bdaeec0ad53531c5d8e89d..4dc999a0e4e6225c021bcea2f32c943897b21be5 100644

--- a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

@@ -165,7 +165,7 @@ const CSSValue* consumeSingleType(const CSSSyntaxComponent& syntax,

case CSSSyntaxType::Time:

return consumeTime(range, ValueRange::ValueRangeAll);

case CSSSyntaxType::Resolution:

- return nullptr; // TODO(timloh): Implement this.

+ return consumeResolution(range);

case CSSSyntaxType::TransformFunction:

return nullptr; // TODO(timloh): Implement this.

case CSSSyntaxType::CustomIdent: