Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2618533002: [intl] Match the new Intl constructor semantics down to details (Closed)

Created:
3 years, 11 months ago by Dan Ehrenberg
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Match the new Intl constructor semantics down to details In spec review, the Intl constructor fallback semantics ended up changing a bit; this patch updates V8 to the newest semantics. BUG=v8:4360, v8:4870 Review-Url: https://codereview.chromium.org/2618533002 Cr-Commit-Position: refs/heads/master@{#43448} Committed: https://chromium.googlesource.com/v8/v8/+/06aeb4eceaea75fd69671c447e25ddaa2fc1dd69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/js/i18n.js View 1 chunk +5 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Dan Ehrenberg
3 years, 10 months ago (2017-02-10 18:10:17 UTC) #7
Yang
lgtm
3 years, 10 months ago (2017-02-14 19:48:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618533002/1
3 years, 9 months ago (2017-02-27 12:23:36 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 12:50:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/06aeb4eceaea75fd69671c447e25ddaa2fc...

Powered by Google App Engine
This is Rietveld 408576698