Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issue 2601833002: [intl] Remove indirection in Intl objects (Closed)

Created:
3 years, 12 months ago by Dan Ehrenberg
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intl] Remove indirection in Intl objects With the new initialization semantics, the V8 ECMA 402 (Intl) implementation does not need to indirect through a symbol to get at the underlying object. This patch removes that indirection, simplifying the implementation. R=yangguo@chromium.org BUG=v8:5751 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2601833002 Cr-Commit-Position: refs/heads/master@{#42281} Committed: https://chromium.googlesource.com/v8/v8/+/db13ed1d4c845d2bb795b3aad93842ebcf89cea4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Removed singleton handle entries #

Patch Set 4 : Fix a dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -180 lines) Patch
M src/bootstrapper.cc View 1 2 5 chunks +19 lines, -4 lines 0 comments Download
M src/contexts.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/global-handles.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap-symbols.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/i18n.h View 6 chunks +20 lines, -18 lines 0 comments Download
M src/i18n.cc View 1 2 4 chunks +5 lines, -38 lines 0 comments Download
M src/js/i18n.js View 1 2 23 chunks +28 lines, -57 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 1 2 3 11 chunks +24 lines, -58 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Dan Ehrenberg
3 years, 12 months ago (2016-12-27 20:16:20 UTC) #8
Yang
On 2016/12/27 20:16:20, Dan Ehrenberg wrote: lgtm.
3 years, 11 months ago (2017-01-09 10:07:31 UTC) #11
Yang
On 2017/01/09 10:07:31, Yang wrote: > On 2016/12/27 20:16:20, Dan Ehrenberg wrote: > > lgtm. ...
3 years, 11 months ago (2017-01-09 10:08:06 UTC) #12
Dan Ehrenberg
On 2017/01/09 10:08:06, Yang wrote: > On 2017/01/09 10:07:31, Yang wrote: > > On 2016/12/27 ...
3 years, 11 months ago (2017-01-12 01:46:24 UTC) #13
Yang
On 2017/01/12 01:46:24, Dan Ehrenberg wrote: > On 2017/01/09 10:08:06, Yang wrote: > > On ...
3 years, 11 months ago (2017-01-12 07:31:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601833002/60001
3 years, 11 months ago (2017-01-12 17:56:05 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:58:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/db13ed1d4c845d2bb795b3aad93842ebcf8...

Powered by Google App Engine
This is Rietveld 408576698