Reland crrev.com/8283cad74e0cad4840d1f with fix for static initializers.

Reland crrev.com/8283cad74e0cad4840d1f with fix for static initializers.

Fix for static initializers is in ui/gfx/vector_icon_types.h

Original description:
Create vector icon resource directory specific to Chrome.

BUG=626786
Review-Url: https://codereview.chromium.org/2610163003

Review-Url: https://codereview.chromium.org/2618403002
Cr-Commit-Position: refs/heads/master@{#442357}
Committed: https://chromium.googlesource.com/chromium/src/+/01876af8d286f290fc12baeae8e4ac08913b9b90

[Evan Stade, 2017-01-09 19:51:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-09 19:52:07]

estade@chromium.org changed reviewers:
+ sky@chromium.org, tdanderson@chromium.org

[sky, 2017-01-09 20:04:28]

Where was the fix (I don't see a diff between patches 1 and 2).

[Evan Stade, 2017-01-09 20:06:18]

side note: There must not be a bot for static initializers on cros because it
should have complained about this pattern in ash/resources/vector_icons, and
this patch fixes that too. There is no CQ bot that runs the static initializers
script, but you can run it manually with a command like

 $ ./linux/dump-static-initializers.py ./out/Release/chrome

and locally this confirms that this patch makes the new SIs go away.

[Evan Stade, 2017-01-09 20:06:41]

On 2017/01/09 20:04:28, sky wrote:
> Where was the fix (I don't see a diff between patches 1 and 2).

Fix for static initializers is in ui/gfx/vector_icon_types.h

[sky, 2017-01-09 20:57:21]

LGTM

[Evan Stade, 2017-01-09 21:00:20]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-01-09 21:00:35]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-09 21:00:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:35:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483995635234370,
"parent_rev": "6fc67b4140d07a660d3b2b6d2eae7a4fd8b6c9dd", "commit_rev":
"01876af8d286f290fc12baeae8e4ac08913b9b90"}

[commit-bot: I haz the power, 2017-01-09 21:36:16]

Description was changed from

==========
Reland crrev.com/8283cad74e0cad4840d1f with fix for static initializers.

Fix for static initializers is in ui/gfx/vector_icon_types.h

Original description:
Create vector icon resource directory specific to Chrome.

BUG=626786
Review-Url: https://codereview.chromium.org/2610163003
==========

to

==========
Reland crrev.com/8283cad74e0cad4840d1f with fix for static initializers.

Fix for static initializers is in ui/gfx/vector_icon_types.h

Original description:
Create vector icon resource directory specific to Chrome.

BUG=626786
Review-Url: https://codereview.chromium.org/2610163003

Review-Url: https://codereview.chromium.org/2618403002
Cr-Commit-Position: refs/heads/master@{#442357}
Committed:
https://chromium.googlesource.com/chromium/src/+/01876af8d286f290fc12baeae8e4...
==========

[commit-bot: I haz the power, 2017-01-09 21:36:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01876af8d286f290fc12baeae8e4...

[Evan Stade, 2017-01-11 02:25:42]

https://codereview.chromium.org/2618403002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_view.cc (left):

https://codereview.chromium.org/2618403002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_view.cc:754:
gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_BACK, disabled_color));
oops