Create vector icon resource directory specific to Chrome.

Create vector icon resource directory specific to Chrome.

BUG=626786
Review-Url: https://codereview.chromium.org/2610163003
Cr-Commit-Position: refs/heads/master@{#442183}
Committed: https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d2244136ffeda

[Evan Stade, 2017-01-04 20:59:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 20:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:17:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-01-04 23:29:07]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 23:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-05 00:52:13]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:52:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:21:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-01-05 16:58:36]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:58:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-05 17:42:27]

estade@chromium.org changed reviewers:
+ oshima@chromium.org, tdanderson@chromium.org

[Evan Stade, 2017-01-05 17:50:39]

Patchset #5 (id:80001) has been deleted

[oshima, 2017-01-05 22:51:19]

lgtm (i'm not the owner though)

[Evan Stade, 2017-01-06 18:08:36]

estade@chromium.org changed reviewers:
+ groby@chromium.org, sky@chromium.org

[Evan Stade, 2017-01-06 18:08:37]

+groby for cocoa
+sky for the rest

[sky, 2017-01-06 20:38:50]

LGTM

[Evan Stade, 2017-01-06 22:03:58]

estade@chromium.org changed reviewers:
+ avi@chromium.org
- groby@chromium.org

[Evan Stade, 2017-01-06 22:03:59]

-groby +avi for cocoa

[Avi (use Gerrit), 2017-01-06 22:11:19]

LGTM with fixed nits.

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm (right):

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm:49: return nil;
gfx::VectorIcon is a C++ object, so use nullptr.

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm (right):

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm:206: return nil;
nullptr

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm (right):

https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm:223: return nil;
nullptr

[Evan Stade, 2017-01-07 00:40:41]

On 2017/01/06 22:11:19, Avi wrote:
> LGTM with fixed nits.
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm (right):
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm:49: return nil;
> gfx::VectorIcon is a C++ object, so use nullptr.
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm (right):
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm:206: return nil;
> nullptr
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm (right):
> 
>
https://codereview.chromium.org/2610163003/diff/60001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm:223: return nil;
> nullptr

thanks. All three done.

[Evan Stade, 2017-01-07 00:40:55]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-07 00:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
oshima@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2610163003/#ps100001
(title: "avi review")

[commit-bot: I haz the power, 2017-01-07 00:41:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 00:58:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-01-07 23:30:32]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-07 23:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
oshima@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2610163003/#ps120001
(title: "merge conflict")

[commit-bot: I haz the power, 2017-01-07 23:30:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-08 00:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-08 00:47:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2017-01-08 17:51:26]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-08 17:51:27]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
oshima@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2610163003/#ps140001
(title: "fix oversight")

[commit-bot: I haz the power, 2017-01-08 17:51:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-08 18:43:30]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483897886886740,
"parent_rev": "197af4aebb2571f08c38c9a68a29908535c5d27f", "commit_rev":
"8283cad74e0cad4840d1f222052d2244136ffeda"}

[commit-bot: I haz the power, 2017-01-08 18:43:57]

Description was changed from

==========
Create vector icon resource directory specific to Chrome.

BUG=626786
==========

to

==========
Create vector icon resource directory specific to Chrome.

BUG=626786

Review-Url: https://codereview.chromium.org/2610163003
Cr-Commit-Position: refs/heads/master@{#442183}
Committed:
https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d...
==========

[commit-bot: I haz the power, 2017-01-08 18:43:59]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d...

[vitaliii, 2017-01-09 08:50:46]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2614333002/ by vitaliii@chromium.org.

The reason for reverting is: Speculative revert, likely broke:

Linux:
https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/3...

Mac:
https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/22402

BUG=679272.