Chromium Code Reviews
DescriptionRevert 158972 "Canonical name change: windows-949 => EUC-KR"
Breaks browser tests as described below - please disable and/or fix those tests
before relanding this change.
> Canonical name change: windows-949 => EUC-KR
>
> This is to be compliant with the HTML5 encoding spec. The expected
> result for encoding-labels.html was updated accordingly to pass EUC-KR
> related tests.
>
> It has to be noted that EUC-KR is a far more widely used encoding label than windows-949. Strictly speaking, Windows-949 is a superset of EUC-KR, but an widely accepted practice in the web is to treat them synonymously as codified in HTML 5.
>
> In addition, 'TextEncoding::domName' became unnecessary
> (http://trac.webkit.org/changeset/43279) so that it's removed.
>
> Note to webkit gardeners:
> Chromium's browser test: BrowserEncodingTest.* will fail with this rolled. A fix is on the way at https://codereview.chromium.org/25769005
>
> BUG=277027
> TEST=fast/encoding/api/* and fast/encoding/euckr-name.html
>
> Review URL: https://codereview.chromium.org/25870005
TBR=jshin@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159023
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||