Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 26184004: Revert 158972 "Canonical name change: windows-949 => EUC-KR" (Closed)

Created:
7 years, 2 months ago by Andrew T Wilson (Slow)
Modified:
7 years, 2 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews
Visibility:
Public.

Description

Revert 158972 "Canonical name change: windows-949 => EUC-KR" Breaks browser tests as described below - please disable and/or fix those tests before relanding this change. > Canonical name change: windows-949 => EUC-KR > > This is to be compliant with the HTML5 encoding spec. The expected > result for encoding-labels.html was updated accordingly to pass EUC-KR > related tests. > > It has to be noted that EUC-KR is a far more widely used encoding label than windows-949. Strictly speaking, Windows-949 is a superset of EUC-KR, but an widely accepted practice in the web is to treat them synonymously as codified in HTML 5. > > In addition, 'TextEncoding::domName' became unnecessary > (http://trac.webkit.org/changeset/43279) so that it's removed. > > Note to webkit gardeners: > Chromium's browser test: BrowserEncodingTest.* will fail with this rolled. A fix is on the way at https://codereview.chromium.org/25769005 > > BUG=277027 > TEST=fast/encoding/api/* and fast/encoding/euckr-name.html > > Review URL: https://codereview.chromium.org/25870005 TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -28 lines) Patch
M trunk/LayoutTests/fast/encoding/api/encoding-labels-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M trunk/LayoutTests/fast/encoding/api/legacy-encode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/wtf/text/TextCodecICU.cpp View 3 chunks +10 lines, -14 lines 0 comments Download
M trunk/Source/wtf/text/TextEncoding.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/wtf/text/TextEncoding.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Andrew T Wilson (Slow)
7 years, 2 months ago (2013-10-07 11:14:07 UTC) #1
Andrew T Wilson (Slow)
7 years, 2 months ago (2013-10-07 11:16:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r159023.

Powered by Google App Engine
This is Rietveld 408576698