Issue 25769005: Canonical encoding name : windows-949 => EUC-KR

Issue 25769005: Canonical encoding name : windows-949 => EUC-KR (Closed)

Created:
7 years, 2 months ago by jungshik at Google

Modified:
7 years, 2 months ago

Reviewers:
jnd, Nico, robertshield

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, jshin+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Canonical encoding name : windows-949 => EUC-KR This is the chromium side of a blink change at https://codereview.chromium.org/25870005 Until the corresponding blink is re-landed (it's landed but reverted), disable EUC-KR-related test temporarily. BUG=277027, 95963 TEST=browser test: BrowserEncodingTest.* and EncodingAlias*.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : LF at the end-of-file dropped to pass test #

Patch Set 6 : disable euc-kr until webkit rolls #

Patch Set 7 : #

Patch Set 8 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -56 lines)			Patch
M	chrome/browser/browser_encoding_browsertest.cc	View	1 2 3 4 5 6	2 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/character_encoding.cc	View	1 2 3 4 5	2 chunks	+1 line, -2 lines	0 comments	Download
A +	chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/test/data/encoding_tests/alias_mapping/windows-949.html	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -14 lines	0 comments	Download
A +	chrome/test/data/encoding_tests/auto_detect/EUC-KR_with_no_encoding_specified.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/test/data/encoding_tests/auto_detect/expected_results/expected_EUC-KR_saved_from_no_encoding_specified.html	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/test/data/encoding_tests/auto_detect/expected_results/expected_windows-949_saved_from_no_encoding_specified.html	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -15 lines	0 comments	Download
D	chrome/test/data/encoding_tests/auto_detect/windows-949_with_no_encoding_specified.html	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome_frame/chrome_active_document.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

robertshield

I don't see reviewers listed, but just in case, the Chrome Frame part LGTM :-) ...

7 years, 2 months ago (2013-10-04 12:38:28 UTC) #2

jungshik at Google

Thanks Robert for your preemptive review. I'll update the title of a page.

7 years, 2 months ago (2013-10-04 19:49:19 UTC) #3

jungshik at Google

thakis, can you review this as well? This is the chrome side of Blink change ...

7 years, 2 months ago (2013-10-04 19:51:18 UTC) #4

Nico

lgtm stamp third_party/sfntly/cpp/src/sfntly/table/core/name_table.cc also has a mention of windows 949 – does that need to ...

7 years, 2 months ago (2013-10-04 21:10:52 UTC) #5

jungshik at Google

Thank you for LGTM. On 2013/10/04 21:10:52, Nico wrote: > lgtm stamp > > third_party/sfntly/cpp/src/sfntly/table/core/name_table.cc ...

7 years, 2 months ago (2013-10-04 23:28:37 UTC) #6

jungshik at Google

Will land after https://codereview.chromium.org/25870005 goes into Blink and gets rolled in.

7 years, 2 months ago (2013-10-05 00:12:04 UTC) #7

Andrew T Wilson (Slow)

On 2013/10/05 00:12:04, Jungshik Shin wrote: > Will land after https://codereview.chromium.org/25870005 goes into Blink and ...

7 years, 2 months ago (2013-10-07 11:03:30 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/25769005/38001

7 years, 2 months ago (2013-10-07 21:40:03 UTC) #9

commit-bot: I haz the power

Failed to apply patch for chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html: While running patch -p0 --forward --force --no-backup-if-mismatch; can't find ...

7 years, 2 months ago (2013-10-07 21:40:11 UTC) #10

jungshik at Google

On 2013/10/07 11:03:30, Andrew T Wilson wrote: > On 2013/10/05 00:12:04, Jungshik Shin wrote: > ...

7 years, 2 months ago (2013-10-07 21:42:15 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/25769005/38001

7 years, 2 months ago (2013-10-07 21:48:08 UTC) #12

commit-bot: I haz the power

7 years, 2 months ago (2013-10-07 21:48:11 UTC) #13

Failed to apply patch for
chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 5
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html
  |===================================================================
  |--- chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html	(revision
226622)
  |+++ chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html	(working copy)
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:   N   chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html
Index: chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html
===================================================================
--- chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html	(revision 226622)
+++ chrome/test/data/encoding_tests/alias_mapping/EUC-KR.html	(working copy)
@@ -1,7 +1,7 @@
 <html>
  <head>
-  <title> windows-949 </title>
-  <meta http-equiv="Content-Type" content="text/html; charset=windows-949" />
+  <title> EUC-KR </title>
+  <meta http-equiv="Content-Type" content="text/html; charset=EUC-KR" />
  </head>
 
  <body>

Expand Messages | Collapse Messages